From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E47CAA0032; Fri, 18 Feb 2022 19:49:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D206D40395; Fri, 18 Feb 2022 19:49:49 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 6A85A40141; Fri, 18 Feb 2022 19:49:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645210189; x=1676746189; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=12SFUVLfzFBwYu6fjpA/dQMQx+HC94xpo6sQfwCnaXY=; b=ivMiB5zSwMi61KnfzCCkW3GUOBW9+7Pwx/He8r97h/BQbXmBKMoq5bOj paU7bLD9TbO3KqR/8BKi94tHXw6fweRCI2fJa8zIaw3RwPIp360cW6pja uKV49E6h5SjDqPKH0RX5S1qOmBZYsKt0Oj8QeBY7VICT2OZkx4qMbCk6G WdN6bwGgsfXo6r8kVZ+EM7J+GXtC6L7P2ortd7PEP2qv6eHTEtGToc2LQ IVfFVzGCnMLUnqLMLjctm2SzV8ZzvartAiT0L9YLwhKwWeHc9WsEyzI9S 3qGU4/QKWZyc2NIM+hTQfCzhelh5D3Os2XUaiLHvuRqWCDKQFjCWVp85v A==; X-IronPort-AV: E=McAfee;i="6200,9189,10262"; a="234724354" X-IronPort-AV: E=Sophos;i="5.88,379,1635231600"; d="scan'208";a="234724354" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2022 10:49:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,379,1635231600"; d="scan'208";a="590293810" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga008.fm.intel.com with ESMTP; 18 Feb 2022 10:49:30 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 18 Feb 2022 10:49:30 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 18 Feb 2022 10:49:29 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 18 Feb 2022 10:49:29 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 18 Feb 2022 10:49:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CtVGagznf3n8ci347bG5E6SBqh19+diy0vMYJeqOslcB0qWnli4qgjDYLPbe9hr9GT/r2Bif+gDTIP5B7pvDsXrq2SimXee7/uf36XlJn3E3e4bXxZ/rnKxwgnqEyv+q07ovYONOMVrdUvsGHIT4Tse5KbjuaLHcEHeVddwoKoPhYGJ/b4cbNIoLymM48Vpt30r8LAVoXzhBuzO/HuWQDeSj7oDsYTfV7j/ZSiQa9uqooK//7TKdXOc1Sq9DAcuk3ovUlMUl/ztsHNdAk1ArX864UTiidj1x0tXoLImVxc1rTcvR7EP1TfM/Q0WW37Wn0W4JUcGX4mPQgFAX+CpDZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V//dMwEjr+Ppk43nHRCYAfyD5yseDfjzo+EBp0wzvYI=; b=WfOv3KQ8N6Z2s630jUPeVl3Q1X9zNBGGNLJc6b9hz4ogeawnwqCQ5XxzIyYt6paALTVLpTbDpy5Qead4yIhoCbOuhm86MHM4Fxfr/zxMY0I3f8JnuRrsf8Z0DYse80Ksn1gi/RjnJJKJ/aWCo6T2jpzwo8TJwpA4z+YzRYJ3y6deAgZw/w1cD2gMPHtu6lphqBQwhI96YgB8JcyFbZ30UAylm2EK7n1DqbayyC0YgHEDVydQSxlNGxtZRMAYIZM5aFaMzcB0qjThZWzzGjrLUce8dzJId+tasrsXZTdl0NOBxFIIbfLOET3RH4KO5R4SAov2w0UEEy6e+fobxF82fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM6PR11MB4219.namprd11.prod.outlook.com (2603:10b6:5:14e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Fri, 18 Feb 2022 18:49:28 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4995.024; Fri, 18 Feb 2022 18:49:28 +0000 Message-ID: <48a33006-80e1-3247-361c-b8b968ef362f@intel.com> Date: Fri, 18 Feb 2022 18:49:23 +0000 Subject: Re: [PATCH 1/2] net/af_xdp: ensure xsk is deleted on Rx queue setup error Content-Language: en-US To: Ciara Loftus , CC: References: <20220218112037.61204-1-ciara.loftus@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20220218112037.61204-1-ciara.loftus@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0119.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::35) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d3da67e5-d6ea-4b85-06b3-08d9f30f6428 X-MS-TrafficTypeDiagnostic: DM6PR11MB4219:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:381; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dFruO4Ewv2jYzdnkIp74AZofygeDSCfwBn5ldX0ImWuelOtbG2n3A7nZRypwJRP7x5hoE6bD2yn1EHatXZg3N7LEcr+IAPbgsLliUQYTMoNrqI6Nhqk5RXE8R35djTXmpmKSggRuR4E82owni6eKt6ThrNH/TEIotNma5IPhzhVrVsSctyDvEjjn4XzdDzfxdpFs/xWbvymFeTzhXEslg9hqEKeYzovXpZgBm+xKIlgd34tPdNdjVeXJ3w5A6mPM9NV1tMDpCuZ0XDGYdoYOTfIqnYSiy9DfbJYO77ceC/ZUEQeO8czf6JmphuOQLVlNjeiPoqkSFxszKz5q+2NJLqGN0jJ3G7eyP03ZQtdtr0xIogLWyErw0go39/I8+pTPXgzhacBYstYbLsWyzkgLjCfdrx5kPZgRgUF626LyUVc2tCfjLxFMoJSMKZsaovZ+xYIFRtZDARQ/DQyBoWzwmQ9FRge1ffgvQggWpMMdpHr2UNJjTo8+IKGxRq2v+s/c2m8YN0iuHh8cdokrOM14RxaPbAI1NWDIYJ6zrGb6aCTtR/dFfpHbXlRmwVCdNmDPqqE1rF/KhEzbp4BfsZqw0gA4pdlzt05VVZSv1aQ1Hggh50EmYX0TOsejxHQs8MsXj/cXWvP0BlNez7u9nYMi/+pnAUdb/erwLpBSQwVeYyhZ8HvIpNRh4EPyc1HWVMP61dzNTF2Wo6m94mRga96rQw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(316002)(31686004)(36756003)(6666004)(6486002)(82960400001)(38100700002)(66476007)(2906002)(8676002)(4326008)(66556008)(66946007)(6512007)(2616005)(508600001)(86362001)(53546011)(8936002)(5660300002)(83380400001)(450100002)(6506007)(186003)(26005)(31696002)(44832011)(4744005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVd3Yk9EeWRkNHZ2YXE5RVBYWkNobXlzbHRPQXRBZGR0OGZ5ZXFSMHFrWlNX?= =?utf-8?B?ZlhZelpxdC9QaFdRWFd1Zk53VEphd1pWKytLUEVhR2lzVEZ3bGZVZUZFSTVj?= =?utf-8?B?eGZSNEx1TXZIaGJ5RGpSUDNwRWVRYkdkQmcyZU9jUUdpNGN2eHlncWMrUlAr?= =?utf-8?B?UGxianlTbnNNRERUZzhBb3NBVWU1blV6NE1FQ0dMd1lzRkd6S1FUUHhzVVpp?= =?utf-8?B?V2ZHdHRJL0JqQlVSTTBEUU5LQWpFeGNraGU1UDVWR3BiMlBIODR4dVZzeDZx?= =?utf-8?B?Q294Z0NNWnVwRlRFNktWVEFDTlpNSXVIZllWMTc5cVBYbW9xaER0VVZyNGRK?= =?utf-8?B?UlMwME5kMkUzTzBLUmJTQjZjMHYyUWlhbVoyMTZGUDZvWmVNMklib1cyYmt4?= =?utf-8?B?WWxmdkdUVU9XREEzSWpud2dMUzRoc0VWS096RGY1K2RiVzhNQjFKekJMU1JQ?= =?utf-8?B?bW1ETEZUcnFZVlgrbG9iUWlYa0NHSjRZTks0bWFsc3N4cVA3Rkhmc0w2d240?= =?utf-8?B?WDFTRkNYMUdVcmFWM0lTK2RWMzQxVHFGcDRBMnRoVmEvOUdMMlQ0eWx1eTd6?= =?utf-8?B?TGJ0aXBuc04yTzFMQTROR2ZjR1JGcnVHdDQxcFh1YzN1RW1XOElzV2hYNmpT?= =?utf-8?B?WDMwWG1XeUh5bG02ZzBsbmVaUGluOVlYNEtNUlprZURHQmlHdXczWml2aXdU?= =?utf-8?B?QlRENzZuZEJwYjlhMzdmdnlKNDAyM1dOdTAvVUJoTVJtRnpWUWduQUVJaG5R?= =?utf-8?B?Y0kwai83ZkphaVd2R1lMUmZwMnhBdG5DcWtRaTFXYTVZY3Y3TCtTOTg2SXZK?= =?utf-8?B?RHdQamR3VlFkSWxrb0V4N3FqT3c4U1ZSdDB4MXJTWWhpM0ZJNmlXT29xWldC?= =?utf-8?B?bWRXemZWL3pKaTFkSkhvN0kybFJDNlc3Z2Z6Y1I3UmwxUUhWR2JxVEhzdnph?= =?utf-8?B?dEdvNlFTdjE3YnVLTW84cmxEeW9lOWtJeDF4VGRCdk5lc0VIU2h4V09DSTRr?= =?utf-8?B?SWovb2dBVlp0Z1hPbUYwc2hNdTMrLzdlL2txZlJteXhEODlPREExRVJPVUsx?= =?utf-8?B?aC9lZHU4a0Jhc3JyUHpJRzluV3Yyek9rM1lneFdGSXlwMkxVMG9HVE9VZ2pB?= =?utf-8?B?QWJtOThNOStiNzd6TmFXOXk3cXhrZzlIUnN4WkFYRE03TU5KSVY5WFZid2Nq?= =?utf-8?B?MkEvRUM1WGFHYmI5SFkzRG9HQnhOc2J0aG81UURtaWJaR3F4SmtMeG56RnFK?= =?utf-8?B?UkZjTXMwUHBTdGhlMGFQb2lJOHpmNXpzcysyb2dvUmVNcFR2U0dBZ3ViejIy?= =?utf-8?B?RWMzM09vZi9FTWhienNaNHdsbnFEN3lieW4zRk9JV2o2VU1oV0NPQWVsczBn?= =?utf-8?B?MVdxMDlpTVdjM0hYbWQ0eG94YWJINDl2RUpuTmNqWmhjMzFwcm5XdG9WMG9E?= =?utf-8?B?WEZTRktXK2s5V3NHaE5lZ3l1WjVJb0FnS2ZOZ2VHV1JUSmpQMktGc3BVWG1Q?= =?utf-8?B?N093emdINzR0TGh6em0rVXlDdGs4cjdsdm5zYzN5WjRNM3ErMXNaZzFGQVd4?= =?utf-8?B?MVM0MWZXT2VSSkkvSGp3UE1kVnRHM2xOaG43S0VrUmQySWNJVENieXpIeTdB?= =?utf-8?B?cGRLMUpuOXMzNGc1ZnErOVI0amxjR2UrRHpYbi9MTkl0NEJ5VHcrOG8xRWwr?= =?utf-8?B?RlRieE5BR3lLSkZ2dnlsUDhjVHRTcDkvZ0FKL21KUlBjMkp2L0xWbkJERHVS?= =?utf-8?B?TDdlQ2FvTElpeW9ZdjlCTDhKMjJiTzd4TWF4RUx4bURoOTVRTlEzNk1lYzUy?= =?utf-8?B?blhYc25wMktqT0R4LzM0OGN0Y3RxM3NBbnRta1VoMUEwTUNWNzcyalpZa3JI?= =?utf-8?B?dk9wQWtXQkkyaDJBQS9jTlgvREV1REdPQUV1eWNKS2I2Sy9KTU5aakRsWFhS?= =?utf-8?B?RE5XRGI5amQ0eFh3MTZEcG9uTTJhL2VzQzdYTnc3WFRCRk5UKzlQN0R4R0dj?= =?utf-8?B?OGJ4b3IzL1JnTjZrelhIT0pLR2czbGo2c0dnbElRYjRBdWlhaGZreUNXaVcx?= =?utf-8?B?VHh5ZUhZck1UeVZxRUZrdHdmaDdvVkFuSmp6WkNHamdmNUd0M1NhVDM5ME1Z?= =?utf-8?B?QldvRmNBMlQrc21jSXBpc3luNWg5WjNJYitvUjRjNzlPeEFWRjJ3YUlIaitn?= =?utf-8?Q?0xFR8l4leo47WR6TgVLIwwc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d3da67e5-d6ea-4b85-06b3-08d9f30f6428 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 18:49:28.3008 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nvcvjo/6cc5y1qabIqaB8Y+xOlYIiRvgtMCffkCQDiX1ngAzfesKhRwKSniWY/IXp2e9Cepb3jxLA+osQaNqFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4219 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/18/2022 11:20 AM, Ciara Loftus wrote: > The Rx queue setup can fail for many reasons eg. failure to setup the > custom program, failure to allocate or reserve fill queue buffers, > failure to configure busy polling etc. When a failure like one of these > occurs, if the xsk is already set up it should be deleted before > returning. This commit ensures this happens. > > Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks") > Fixes: 288a85aef192 ("net/af_xdp: enable custom XDP program loading") > Fixes: 055a393626ed ("net/af_xdp: prefer busy polling") > Fixes: 01fa83c94d7e ("net/af_xdp: workaround custom program loading") > Cc:stable@dpdk.org > > Signed-off-by: Ciara Loftus Series applied to dpdk-next-net/main, thanks.