From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 0995E330D for ; Wed, 3 May 2017 19:06:41 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id u65so153741252wmu.1 for ; Wed, 03 May 2017 10:06:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=reply-to:subject:references:to:cc:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=o60OGQzrYUY2YSXjnNwtho7wX2VYC3JmUSaQu2MRi9s=; b=ojE19nCmSdtqAwl0xY6yt7HqQqhFfQ6wv/bnmdh+y9J6I97wDT1Osw1Mx8NmpA9jPF UT8eENccD2Z/3WlAPNxk255EeqgQ/KoS+RJy72sKsNVBOYTQeutzRYeelX+scJpGmfFu FEr5mIbSnwoBuMIEWK+qSOLILp0kGIADwdtv05VgAZNVZpzLMOcnKtofbRbYLhzsiJNn BnqOl/OexvPVwSgVo/A/72ok3DG+N6BCG+tZ8Vr/z1LjG0J+0pLsbo17BWmhr3NTN4gY fLVqlAzuRsWFalZxA/LTyVlLsLkeKuHB1D576+ksoY5j4kCv2E73NfokkAR62oZ9+q97 XmEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:references:to:cc:from :organization:message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding; bh=o60OGQzrYUY2YSXjnNwtho7wX2VYC3JmUSaQu2MRi9s=; b=SKWo9CeTJpA18mqXua4Rhb6qT+v8ZLB9hXZeZpWCSN+xoTrVy0AbLe+3wvuWWP4TBu mYyDDgKx59EQ2ikV6shLI3wHPCN3J2q3MMZTVsw/VSqJrnrQbGiRpPH/Hzboa2lZpiT8 dvXxjWhv30xynD630qOo32LVweyiU37fisrCByDzVR5U0CUpp1vzLZKlg2TkmZDvnY6A L44N/tjMmnY5vmgxPqjgud17D9HeYFRQErQnbfvqc9N+2j/ZFPlo+sSrpfNs6v+nRycy P2hKq4/r9J6TDs4/2mTsFyLHMHK1ZrS6lefbxKBS43UY5SdsAbY1iEakrzDKd8mRzOQ2 RJRQ== X-Gm-Message-State: AN3rC/751G8sbQE9xa4Mo+FM/8oXrJ1Vu3Y/aUyEen606q7MeHqacakI iqLaBb3AMGcVobGw X-Received: by 10.28.87.70 with SMTP id l67mr949926wmb.46.1493831201685; Wed, 03 May 2017 10:06:41 -0700 (PDT) Received: from [10.16.0.164] (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id a197sm1387556wma.1.2017.05.03.10.06.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 May 2017 10:06:40 -0700 (PDT) References: <20170503160016.31375-1-ferruh.yigit@intel.com> To: Ferruh Yigit , Thomas Monjalon Cc: dev@dpdk.org From: Nicolas Dichtel Organization: 6WIND Message-ID: <48ab36d4-db15-4a46-dc8e-03954ed55452@6wind.com> Date: Wed, 3 May 2017 19:06:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] kni: fix ethtool build with kernel 4.11 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: nicolas.dichtel@6wind.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 May 2017 17:06:42 -0000 Le 03/05/2017 à 18:43, Ferruh Yigit a écrit : > On 5/3/2017 5:39 PM, Nicolas Dichtel wrote: >> Le 03/05/2017 à 18:00, Ferruh Yigit a écrit : >>> build error: >>> .../build/build/lib/librte_eal/linuxapp/kni/igb_main.c:1034:10: >>> error: implicit declaration of function ‘pci_enable_msix’ >>> [-Werror=implicit-function-declaration] >>> err = pci_enable_msix(pdev, >>> ^~~~~~~~~~~~~~~ >>> >>> This build error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option >>> enabled. >>> >>> Following Linux commit removes the pci_enable_msix() >>> Linux: 4244de1c64de ("PCI: remove pci_enable_msix") >>> >>> Switch to pci_enable_msix_range() for kernel > 4.8 since current Linux >>> igb driver uses this function. >> When looking at the kernel patches, it seems that the way to go is to use >> pci_alloc_irq_vectors(), but it needs a bit more work. > > I remember this from your igb_uio fix, but latest igb kernel driver uses > pci_enable_msix_range(), I found it easy and safe to replicate it. Ok. > > We can update it when kernel igb driver updates the code, unless you > have a strong opinion to switch pci_alloc_irq_vectors() in advance? No, I don't mind. Acked-by: Nicolas Dichtel Regards, Nicolas