From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D5DCC42C4C;
	Wed,  7 Jun 2023 10:28:48 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C89F540A84;
	Wed,  7 Jun 2023 10:28:48 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id C085640698
 for <dev@dpdk.org>; Wed,  7 Jun 2023 10:28:47 +0200 (CEST)
Received: from [192.168.1.39] (unknown [188.170.81.161])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id AA15D59;
 Wed,  7 Jun 2023 11:28:46 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru AA15D59
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1686126527;
 bh=bdkkPwQgCt9tH57Km448eHEktPtZhBqFOX8jXlPK6lM=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=voYvImJMNLaZBiow0AlAvpyxiniLm6vJpdnxHN3LuUeWBJD5Q7RK+4XgP1RCGao8W
 xSfYhT5kgzNNZf2FA4BNS/7F1W07jbNOYwhX+YQDMm3pMo4SwGbdeUfeverBc0V/tO
 wZSz2v5aC25sDzDW5ZjMaluG4KRl940k7QweCcfU=
Message-ID: <48ea4d3e-cb74-1b17-2405-f02550483a6d@oktetlabs.ru>
Date: Wed, 7 Jun 2023 11:28:45 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH 3/4] common/sfc_efx/base: add support for configure MAC to
 keep FCS
Content-Language: en-US
To: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>, dev@dpdk.org
Cc: Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>,
 Ferruh Yigit <ferruh.yigit@amd.com>,
 Roman Zhukov <roman.zhukov@arknetworks.am>,
 Andy Moreton <amoreton@xilinx.com>
References: <20230601114220.17796-1-denis.pryazhennikov@arknetworks.am>
 <20230601114220.17796-4-denis.pryazhennikov@arknetworks.am>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
In-Reply-To: <20230601114220.17796-4-denis.pryazhennikov@arknetworks.am>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 6/1/23 14:42, Denis Pryazhennikov wrote:
> Drivers cannot determine if received packet includes the FCS or not.
> Only packets with an external port have the FCS included and functions
> without link control privilege cannot determine the MAC configuration.
> This patch is trying to make assumptions that: if PF is the only function
> (there are no VFs or additional PFs); it can set the MAC configuration and
> it never expects packets it sends to be looped back then it can assume that
> changed the MAC configuration to include the FCS is safe and that all
> received packets will include their FCS.
> 
> Signed-off-by: Roman Zhukov <roman.zhukov@arknetworks.am>
> Signed-off-by: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>
> Reviewed-by: Andy Moreton <amoreton@xilinx.com>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

Please, ensure that initial author of the patch is used in From.