From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 982C51BEB9 for ; Wed, 4 Jul 2018 21:47:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jul 2018 12:47:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,308,1526367600"; d="scan'208";a="70121891" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.83]) ([10.237.221.83]) by orsmga001.jf.intel.com with ESMTP; 04 Jul 2018 12:47:50 -0700 To: Ophir Munk , "Wiles, Keith" , Thomas Monjalon Cc: "dev@dpdk.org" , Pascal Mazon , Olga Shern References: <1528733172-24747-1-git-send-email-ophirmu@mellanox.com> <3694221.zYt2n70HGy@xps> <2FAE2DE7-DB89-42F8-9010-E522187248AD@intel.com> <2475252.9oVMbiDvHd@xps> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsF+BBMBAgAoAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAUCWZR3VQUJB33WBQAKCRD5M+tD3xNhH6DWEACVhEb8q1epPwZrUDoxzu7E TS1b8tmabOmnjXZRs6+EXgUVHkp2xxkCfDmL3pa5bC0G/74aJnWjNsdvE05V1cb4YK4kRQ62 FwDQ+hlrFrwFB3PtDZk1tpkzCRHvJgnIil+0MuEh32Y57ig6hy8yO8ql7Lohyrnpfk/nNpm4 jQGEF5qEeHcEFe1AZQlPHN/STno8NZSz2nl0b2cw+cujN1krmvB52Ah/2KugQ6pprVyrGrzB c34ZQO9OsmSjJlETCZk6EZzuhfe16iqBFbOSadi9sPcJRwaUQBid+xdFWl7GQ8qC3zNPibSF HmU43yBZUqJDZlhIcl6/cFpOSjv2sDWdtjEXTDn5y/0FsuY0mFE78ItC4kCTIVk17VZoywcd fmbbnwOSWzDq7hiUYuQGkIudJw5k/A1CMsyLkoUEGN3sLfsw6KASgS4XrrmPO4UVr3mH5bP1 yC7i1OVNpzvOxtahmzm481ID8sk72GC2RktTOHb0cX+qdoiMMfYgo3wRRDYCBt6YoGYUxF1p msjocXyqToKhhnFbXLaZlVfnQ9i2i8jsj9SKig+ewC2p3lkPj6ncye9q95bzhmUeJO6sFhJg Hiz6syOMg8yCcq60j07airybAuHIDNFWk0gaWAmtHZxLObZx2PVn2nv9kLYGohFekw0AOsIW ta++5m48dnCoAc7BTQRX1ky+ARAApzQNvXvE2q1LAS+Z+ni2R13Bb1cDS1ZYq1jgpR13+OKN ipzd8MPngRJilXxBaPTErhgzR0vGcNTYhjGMSyFIHVOoBq1VbP1a0Fi/NqWzJOowo/fDfgVy K4vuitc/gCJs+2se4hdZA4EQJxVlNM51lgYDNpjPGIA43MX15OLAip73+ho6NPBMuc5qse3X pAClNhBKfENRCWN428pi3WVkT+ABRTE0taxjJNP7bb+9TQYNRqGwnGzX5/XISv44asWIQCaq vOkXSUJLd//cdVNTqtL1wreCVVR5pMXj7VIrlk07fmmJVALCmGbFr53BMb8O+8dgK2A5mitM n44d+8KdJWOwziRxcaMk/LclmZS3Iv1TERtiWt98Y9AjeAtcgYPkA3ld0BcUKONogP8pHVz1 Ed3s5rDQ91yr1S0wuAzW91fxGUO4wY+uPmxCtFVuBgd9VT9NAKTUL0qHM7CDgCnZPe0TW6Zj 8OqtdCCyAfvU9cW5xWM7Icxhde6AtPxhDSBwE8fL2ZmrDmaA4jmUKXp3i4JxRPSX84S08b+s DWXHPxy10UFU5A7EK/BEbZAKBwn9ROfm+WK+6X5xOGLoRE++OqNuUudxC1GDyLOPaqCbBCS9 +P6HsTHzxsjyJa27n4jcrcuY3P9TEcFJYSZSeSDh8mVGvugi0exnSJrrBZDyVCcAEQEAAcLB ZQQYAQIADwIbDAUCWZR1ZwUJA59cIQAKCRD5M+tD3xNhH5b+D/9XG44Ci6STdcA5RO/ur05J EE3Ux1DCHZ5V7vNAtX/8Wg4l4GZfweauXwuJ1w7Sp7fklwcNC6wsceI+EmNjGMqfIaukGetG +jBGqsQ7moOZodfXUoCK98gblKgt/BPYMVidzlGC8Q/+lZg1+o29sPnwImW+MXt/Z5az/Z17 Qc265g+p5cqJHzq6bpQdnF7Fu6btKU/kv6wJghENvgMXBuyThqsyFReJWFh2wfaKyuix3Zyj ccq7/blkhzIKmtFWgDcgaSc2UAuJU+x9nuYjihW6WobpKP/nlUDu3BIsbIq09UEke+uE/QK+ FJ8PTJkAsXOf1Bc2C0XbW4Y2hf103+YY6L8weUCBsWC5VH5VtVmeuh26ENURclwfeXhWQ9Og 77yzpTXWr5g1Z0oLpYpWPv745J4bE7pv+dzxOrFdM1xNkzY2pvXph/A8OjxZNQklDkHQ7PIB Lki5L2F4XkEOddUUQchJwzMqTPsggPDmGjgLZrqgO+s4ECZK5+nLD3HEpAbPa3JLDaScy+90 Nu1lAqPUHSnP3vYZVw85ZYm6UCxHE4VLMnnJsN09ZhsOSVR+GyP5Nyw9rT1V3lcsuH7M5Naa 2Xobn9m7l9bRCD/Ji8kG15eV1WTxx1HXVQGjdUYDI7UwegBNbwMLh17XDy+3sn/6SgcqtECA Q6pZKA2mTQxEKMLBZQQYAQIADwIbDAUCWZR3hQUJA59eRwAKCRD5M+tD3xNhH4a/D/4jLAZu UhvU1swWcNEVVCELZ0D3LOV14XcY2MXa3QOpeZ9Bgq7YYJ4S5YXK+SBQS0FkRZdjGNvlGZoG ZdpU+NsQmQFhqHGwX0IT9MeTFM8uvKgxNKGwMVcV9g0IOqwBhGHne+BFboRA9362fgGW5AYQ zT0mzzRKEoOh4r3AQvbM6kLISxo0k1ujdYiI5nj/5WoKDqxTwwfuN1uDUHsWo3tzenRmpMyU NyW3Dc+1ajvXLyo09sRRq7BnM99Rix1EGL8Qhwy+j0YAv+FuspWxUX9FxXYho5PvGLHLsHfK FYQ7x/RRbpMjkJWVfIe/xVnfvn4kz+MTA5yhvsuNi678fLwY9hBP0y4lO8Ob2IhEPdfnTuIs tFVxXuelJ9xAe5TyqP0f+fQjf1ixsBZkqOohsBXDfje0iaUpYa/OQ/BBeej0dUdg2JEu4jAC x41HpVCnP9ipLpD0fYz1d/dX0F/VY2ovW6Eba/y/ngOSAR6C+u881m7oH2l0G47MTwkaQCBA bLGXPj4TCdX3lftqt4bcBPBJ+rFAnJmRHtUuyyaewBnZ81ZU2YAptqFM1kTh+aSvMvGhfVsQ qZL2rk2OPN1hg+KXhErlbTZ6oPtLCFhSHQmuxQ4oc4U147wBTUuOdwNjtnNatUhRCp8POc+3 XphVR5G70mnca1E2vzC77z+XSlTyRA== Message-ID: <48f3aef6-765d-66d4-305c-541bd2aa3eb7@intel.com> Date: Wed, 4 Jul 2018 20:47:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1] net/tap: explain how to compile eBPF C file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jul 2018 19:47:54 -0000 On 6/12/2018 3:02 PM, Ophir Munk wrote: > Please note that other than cloning iproute2 we also need to install clang and llvm tools versions 3.7 and upper. > Not sure there are clang and llvm packages of the required versions for the common distributions. > I compiled the tools source code and installed them manually. Hi Keith, Thomas, What do you suggest on this patch? The "tap_bpf_program.c" is already withing the tap pmd this patch improves the doc about how to compile it, although it may not be so user friendly as Keith pointed, I believe better to get doc improvement here. And there is a code update "+#include "bpf_api.h", which includes a iproute2 header, I am not sure about this one and how to manage this dependency. > >> -----Original Message----- >> From: Wiles, Keith [mailto:keith.wiles@intel.com] >> Sent: Tuesday, June 12, 2018 4:53 PM >> To: Thomas Monjalon >> Cc: dev@dpdk.org; Ophir Munk ; Pascal Mazon >> ; Olga Shern >> Subject: Re: [dpdk-dev] [PATCH v1] net/tap: explain how to compile eBPF C >> file >> >> >> >>> On Jun 12, 2018, at 8:44 AM, Thomas Monjalon >> wrote: >>> >>> 12/06/2018 15:33, Wiles, Keith: >>>> >>>>> On Jun 12, 2018, at 7:58 AM, Thomas Monjalon >> wrote: >>>>> >>>>> 12/06/2018 14:36, Wiles, Keith: >>>>>> >>>>>>> On Jun 12, 2018, at 7:26 AM, Thomas Monjalon >> wrote: >>>>>>> >>>>>>> 11/06/2018 18:35, Wiles, Keith: >>>>>>>> >>>>>>>>> On Jun 11, 2018, at 11:06 AM, Ophir Munk >> wrote: >>>>>>>>> >>>>>>>>> This commit explains how to manually compile the C source file >>>>>>>>> tap_bpf_program.c into an ELF file using the clang compiler. >>>>>>>>> The code in tap_bpf_program.c requires definitions found in >>>>>>>>> iproute2 source code. This commit suggests cloning the iproute2 >>>>>>>>> git tree and include its path in the clang command. It also adds >>>>>>>>> inclusion of file bpf_api.h (required for eBPF definitions) >>>>>>>>> which is located in iproute2 source tree. For more details refer to >> TAP documentation. >>>>>>>>> This commit is related to commits [1] and [2]. >>>>>>>> >>>>>>>> Normally I would have suggested that eBPF be disable in the TAP >> driver as it requires external code and programs, but that ship has sailed. >>>>>>> >>>>>>> The external programs are required only to generate new >>>>>>> instructions, changing the behaviour of the BPF program. >>>>>>> Currently, the instructions for RSS behaviour are provided. >>>>>>> >>>>>>>> I would like to see building the tap_bpf_program.o as a target in the >> Makefile, this way the developer can just run the ‘make bpf_program’ target >> and it would be simpler and less error prone. >>>>> >>>>> As explained in the documentation, for now there is a dependency on >>>>> iproute2 for the compilation of this BPF program. >>>>> So we cannot make it as simple as a "make command". >>>>> Probably that we can rework it to change the dependency. >>>>> I heard there are some good BPF libraries available now? >>>> >>>> Well the dependence of iproute2 is really no different then requiring say >> libnuma, they just have to pull the code first to type the ‘make bpf_program’ >> right? >>> >>> The iproute2 dependency is different because it is not a library. >>> The .h file is never packaged. >>> So we need to download the sources and set -I to this directory. >> >> To eliminate the -I problem the clone could be done inside the tap directory >> and -I ./iproute2/include used, right? >> The make target could even clone the code into the tap directory, which >> means we can solve these problems you are pointing out. >> >> Go ahead and do what you want here, but making it harder for the developer >> should not be our normally mode of operation. >> >>> >>> >>>> If that is the case then a make target make sense to me. If iproute2 is not >> found then an error, right? >>> >>> >>>>>>> For this to happen, we need to improve the tools. >>>>>> >>>>>> In what way do we need to improve the tools and which tools are we >> talking about. Building the .o file below appears to be a simple set of >> command lines. I have a question in my original email about what tool. >>>>> >>>>> The .o file is only the an intermediate file. >>>>> The next step (numbered as 5 in this patch) is to extract the >>>>> section of BPF instructions to be uploaded in the kernel. >>>>> This step must be done by a "tool". Ophir did it by hacking tc, but >>>>> it is not upstreamed yet. >>>>> There could be other ways (possibly easier) to achieve the same result. >>>> >>>> Please change the doc to reflect the tool is not upstreamed yet and the >> developer needs to figure out how to extract the data from the binary. >>>> >>>> I used objdump -j l3_l4 -s tap_bpf_program.o and got a hex dump of >>>> the l3_l4 section >>>> >>>> 0000 bf160000 00000000 61681000 00000000 ... >>>> >>>> Someone schooled in the art of Python coding should be able to >>>> convert that output to a ‘C’ data array. :-) >>>> >>>>> >>>>>>> It is a work in progress. >>>>> >>>>> Contributions are welcome. >>>>> >>>>>>> This is a very first step to use Linux BPF with DPDK. >>>>>>> If there are more interests, we should really streamline its usage >>>>>>> for all parts of DPDK which runs on top of some kernel code. >>>>>> >>>>>> streamlining other parts of DPDK would be nice, but we are now talking >> about the tap/eBPF patch. >>>> >>>> Regards, >>>> Keith >> >> Regards, >> Keith >