From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D5B6A0C4B; Sat, 18 Sep 2021 08:50:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09FFB40689; Sat, 18 Sep 2021 08:50:30 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 6F24A40041 for ; Sat, 18 Sep 2021 08:50:28 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id EF3337F529; Sat, 18 Sep 2021 09:50:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru EF3337F529 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1631947828; bh=dmBdBGP2PaDA5I7HPmaQ8EIpayEr1Gper0/FUMiTYXs=; h=Subject:To:References:From:Date:In-Reply-To; b=oW11CTsV99F+uPfRJXZBjRbt8sCe06dc+tuToAGvR+i+7lE4ljb9kCt2dCZHYsVPN xUnN9ETBDe2GEe0n/a8TwQmSTvWlYpfYnh80VnU3A8qJoIC3mB4eroW1qW1qv0cmdA wIVcMBVljFJro8JDvyTDeDxijMPybOIjC1AylcIU= To: Xueming Li , dev@dpdk.org References: <20210727034134.20556-1-xuemingl@nvidia.com> <20210917142834.35352-1-xuemingl@nvidia.com> <20210917142834.35352-3-xuemingl@nvidia.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <48f3c92e-7338-59ed-06cc-248bf633b65f@oktetlabs.ru> Date: Sat, 18 Sep 2021 09:50:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210917142834.35352-3-xuemingl@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 2/2] ethdev: change queue release callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/17/21 5:28 PM, Xueming Li wrote: > Currently, most ethdev callback API use queue ID as parameter, but Rx > and Tx queue release callback use queue object which is used by Rx and > Tx burst data plane callback. > > To align with other eth device queue configuration callbacks: > - queue release callbacks are changed to use queue ID > - all drivers are adapted > > Signed-off-by: Xueming Li One nit below, other than that ethdev Reviewed-by: Andrew Rybchenko > diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h > index 40e474aa7e..524757cf6f 100644 > --- a/lib/ethdev/ethdev_driver.h > +++ b/lib/ethdev/ethdev_driver.h > @@ -282,7 +282,8 @@ typedef int (*eth_rx_disable_intr_t)(struct rte_eth_dev *dev, > uint16_t rx_queue_id); > /**< @internal Disable interrupt of a receive queue of an Ethernet device. */ > > -typedef void (*eth_queue_release_t)(void *queue); > +typedef void (*eth_queue_release_t)(struct rte_eth_dev *dev, > + uint16_t rx_queue_id); Since the callback is shared by Rx and Tx, it should not be rx_queue_id. Just queue_id. > /**< @internal Release memory resources allocated by given RX/TX queue. */ > > typedef int (*eth_fw_version_get_t)(struct rte_eth_dev *dev,