From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ciara Power <ciara.power@intel.com>,
thomas@monjalon.net, arybchenko@solarflare.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: add comment to warn of ABI breakage
Date: Tue, 18 Feb 2020 18:40:40 +0000 [thread overview]
Message-ID: <48feed74-aaf6-fe29-838c-fd16a4b8e818@intel.com> (raw)
In-Reply-To: <20200218133944.13145-1-ciara.power@intel.com>
On 2/18/2020 1:39 PM, Ciara Power wrote:
> If a function is added to the eth_dev_ops struct before
> tx_descriptor_status function, this will cause ABI breakage. This is due
> to static inline functions using this function, and some other functions
> above it in the struct, so they cannot change position. A comment is
> added to inform developers of this possible breakage.
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Applied to dpdk-next-net/master, thanks.
(uppercase ABOVE/BELOW as suggested applied while merging)
prev parent reply other threads:[~2020-02-18 18:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 10:46 [dpdk-dev] [PATCH] " Ciara Power
2020-02-18 11:59 ` Ferruh Yigit
2020-02-18 13:13 ` Andrew Rybchenko
2020-02-18 14:20 ` Thomas Monjalon
2020-02-18 13:39 ` [dpdk-dev] [PATCH v2] " Ciara Power
2020-02-18 18:40 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48feed74-aaf6-fe29-838c-fd16a4b8e818@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).