From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jim Harris <james.r.harris@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] contigmem: zero all pages during mmap
Date: Mon, 22 Aug 2016 22:58:46 +0200 [thread overview]
Message-ID: <4904186.gj4j9rRC36@xps13> (raw)
In-Reply-To: <20160816224646.1982.50720.stgit@jrharri1-mac>
2016-08-16 15:46, Jim Harris:
> On Linux, all huge pages are zeroed by the kernel before
> first access by the DPDK application. But on FreeBSD,
> the contigmem driver would only zero the contiguous
> memory regions during initial driver load.
>
> DPDK commit b78c91751 eliminated the explicit memset()
> operation for rte_zmalloc(), which was OK on Linux
> because the kernel zeroes the pages during app start,
> but this broke FreeBSD. So this patch explicitly
> zeroes the pages before they are mmap'd, to ensure
> equivalent behavior to Linux
Added precision that the bug is seen "when restarting app".
> Fixes: b78c9175118f ("mem: do not zero out memory on zmalloc")
>
> Reported-by: Daniel Verkamp <daniel.verkamp@intel.com>
> Tested-by: Daniel Verkamp <daniel.verkamp@intel.com>
> Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
> Signed-off-by: Jim Harris <james.r.harris@intel.com>
Applied, thanks
CC stable@, please pick this important fix in 16.07.
prev parent reply other threads:[~2016-08-22 20:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 22:46 Jim Harris
2016-08-22 20:58 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4904186.gj4j9rRC36@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=james.r.harris@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).