From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id A8BAE388F for ; Mon, 22 Aug 2016 22:58:48 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id o80so164281259wme.1 for ; Mon, 22 Aug 2016 13:58:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=R6bXCAyopogz3cvpTnt48425mjoj74vYP4qvGKGA6nY=; b=wS+dDOE4Xtyp0KMhtwyjXij+FJ4eLz+H3p0bUvhHc9U979AZ7KgpNa1ka6+8kfWzBa nCKPQaxk9z4E+iSMmXCuTKS8phKGZlEGDawYJMPdmP4D40UXjjE97ncjchWgtM48pEGK lEajopupIW3zvj0eeUgTrLBRpwRxeMBoY5b37GjqmRT24o+P6hxpW9my6KuKBT6uhYe/ h0ml66EkPEt8o1VcjGP2aUY/kSn2tylJTeEFeRKk6scxbr2MLJqWf3eg+MV4l2EBnC3v o+IGVMx2FWlKxwBEXEeVbjxr+xhQRNCmHqjjmO6rC8mWL9g/5FkR9qIE544FDd3dKZPq uhyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=R6bXCAyopogz3cvpTnt48425mjoj74vYP4qvGKGA6nY=; b=kffufADWUaTYMe3Y8WyLO80HA7vp8Mci3LeVk9TJnc7EoGkWOuyTwQ9aZSHb6dyHkS QOFfvJeHuMFAmYcSH9inSVrQvjgLiGHC+JdpGmJx/joWhxfZcf331VoRyxMIcNd2XqmL 04P79lUgnwFUEekzxE3HuL/OVzBGt9jebkY15IIGd5YMrAaAXbaIB8P8VsbrETEpjk7X tb1HXKglqTKibYu2ysstFcbZC5eidWpHa7hcOWlROeAfmTsZSeMRuGT6Dv6CqTWCwDoI NlIkijojDm8PRfnOSvIschvBTcUOF5MCWIsyYxEb0swBUWMKfhn17RV0z3tXiKX3sLV+ jRVw== X-Gm-Message-State: AEkoouszkffBFzaDRKJ6vja3hFOd0jNfuJq65HEQSuHfyx2lRsBSL25319h22YwRykFt1sM1 X-Received: by 10.28.154.21 with SMTP id c21mr16054036wme.63.1471899528341; Mon, 22 Aug 2016 13:58:48 -0700 (PDT) Received: from xps13.localnet (171.17.90.79.rev.sfr.net. [79.90.17.171]) by smtp.gmail.com with ESMTPSA id v134sm23614565wmf.10.2016.08.22.13.58.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Aug 2016 13:58:47 -0700 (PDT) From: Thomas Monjalon To: Jim Harris Cc: dev@dpdk.org, stable@dpdk.org Date: Mon, 22 Aug 2016 22:58:46 +0200 Message-ID: <4904186.gj4j9rRC36@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160816224646.1982.50720.stgit@jrharri1-mac> References: <20160816224646.1982.50720.stgit@jrharri1-mac> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] contigmem: zero all pages during mmap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Aug 2016 20:58:48 -0000 2016-08-16 15:46, Jim Harris: > On Linux, all huge pages are zeroed by the kernel before > first access by the DPDK application. But on FreeBSD, > the contigmem driver would only zero the contiguous > memory regions during initial driver load. > > DPDK commit b78c91751 eliminated the explicit memset() > operation for rte_zmalloc(), which was OK on Linux > because the kernel zeroes the pages during app start, > but this broke FreeBSD. So this patch explicitly > zeroes the pages before they are mmap'd, to ensure > equivalent behavior to Linux Added precision that the bug is seen "when restarting app". > Fixes: b78c9175118f ("mem: do not zero out memory on zmalloc") > > Reported-by: Daniel Verkamp > Tested-by: Daniel Verkamp > Acked-by: Sergio Gonzalez Monroy > Signed-off-by: Jim Harris Applied, thanks CC stable@, please pick this important fix in 16.07.