From: Thomas Monjalon <thomas@monjalon.net>
To: Anoob Joseph <anoobj@marvell.com>
Cc: Akhil Goyal <gakhil@marvell.com>,
Fan Zhang <fanzhang.oss@gmail.com>,
Jerin Jacob <jerinj@marvell.com>,
dev@dpdk.org, david.marchand@redhat.com, ciara.power@intel.com
Subject: Re: [PATCH] cryptodev: clarify error codes returned
Date: Sun, 11 Jun 2023 12:05:29 +0200 [thread overview]
Message-ID: <4904381.0VBMTVartN@thomas> (raw)
In-Reply-To: <20230424091920.660-1-anoobj@marvell.com>
24/04/2023 11:19, Anoob Joseph:
> When symmetric sessions are created, it may fail due to non-critical
> errors. When PMD doesn't support the specific combination that
> application requested, it can return -ENOTSUP which can be handled so in
> application. The API is already setting rte_errno according to the
> reason of the failure. Clarifying this in the spec to list down possible
> error codes.
>
> Fixes: bdce2564dbf7 ("cryptodev: rework session framework")
>
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
[...]
> * @return
> * - On success return pointer to sym-session.
> - * - On failure returns NULL.
> + * - On failure returns NULL and rte_errno is set to the error code.
> + * EINVAL on invalid arguments.
> + * ENOMEM on memory error for session allocation.
> + * ENOTSUP if device doesn't support session configuration.
If you don't make bullets, all lines are rendered on the same line, without any separator:
"
Returns
On success return pointer to sym-session.
On failure returns NULL and rte_errno is set to the error code. EINVAL on invalid arguments. ENOMEM on memory error for session allocation. ENOTSUP if device doesn't support session configuration.
"
In general, you must check the HTML rendering of the doc changes.
I am fixing while pulling.
prev parent reply other threads:[~2023-06-11 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 9:19 Anoob Joseph
2023-05-08 12:32 ` Power, Ciara
2023-05-16 10:43 ` Akhil Goyal
2023-05-24 10:59 ` Akhil Goyal
2023-06-11 10:05 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4904381.0VBMTVartN@thomas \
--to=thomas@monjalon.net \
--cc=anoobj@marvell.com \
--cc=ciara.power@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).