From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7542742C89; Sun, 11 Jun 2023 12:05:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 01ED040A79; Sun, 11 Jun 2023 12:05:38 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id B4EAC400D5 for ; Sun, 11 Jun 2023 12:05:36 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 1841D32003C0; Sun, 11 Jun 2023 06:05:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sun, 11 Jun 2023 06:05:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1686477932; x=1686564332; bh=bWCAzk3/hf4086KHQX9g9mA0vYA1YwHxzCU aLgv3aXI=; b=LydLrE1nJQFmb0rGnwmqhoOWscd7nGsNFeSMrsrR0yVVvxKbP3s DyQHlvt0SO1XRPhIZOk1huLcBKjpdLOPNpQtHa+1v4BipEp0CpQlHF1tfBrs/+Ej K9XZwQf4u1g2llBjeE/sxmcspOPi81d3f9qVYBvUxFMI/Hk2uUp/7Px/5vXtzngy cHbaGnYkHrwx2vMYr4J/7+EwX1KqpbWXY6/7ri8v1X5XQG5l3DPTA2wxxln6NHWQ Anim9YLb/wTX58ru4XPsT26cd0DyVRmFlTRU79IG6JnRLcQmpqJjUdQEb/7nxc9m oTIcLFw5nJFQ/fY3EwUPGhK9/RkZ2LyomOg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1686477932; x=1686564332; bh=bWCAzk3/hf4086KHQX9g9mA0vYA1YwHxzCU aLgv3aXI=; b=EHngnqz4+rLgr3Edyzm67LAD9LQQMWGxDjvyPTZWKFQwQMXqDwR LoCrUmhfxWPAyWeTwO4h0TvaFq/wcJCj+Hww+jTrNg4RcGeZJGcNPAjogidXnMgN +F51hVkpBcZI7s+Kont7NAqHXrMuB+0aDHhGIHYU3n6ZmoLNi258rIIsHv/XpKUb SdTyLouq/6g6lis0fzS3xjNxKOllyNfuI+G9ugCcSrZAXhxLuIphCVSEf0RjmwCF xHkhuEp7ZqZLU+ASRW8PR7ioPw8KlmKB+ipABPL+1xDaTTkIEmFoJMaV+DEycXBf 01UXFazvXIxmprqI0cknPKC1NR1QvGFkWUg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeduvddgvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 11 Jun 2023 06:05:31 -0400 (EDT) From: Thomas Monjalon To: Anoob Joseph Cc: Akhil Goyal , Fan Zhang , Jerin Jacob , dev@dpdk.org, david.marchand@redhat.com, ciara.power@intel.com Subject: Re: [PATCH] cryptodev: clarify error codes returned Date: Sun, 11 Jun 2023 12:05:29 +0200 Message-ID: <4904381.0VBMTVartN@thomas> In-Reply-To: <20230424091920.660-1-anoobj@marvell.com> References: <20230424091920.660-1-anoobj@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 24/04/2023 11:19, Anoob Joseph: > When symmetric sessions are created, it may fail due to non-critical > errors. When PMD doesn't support the specific combination that > application requested, it can return -ENOTSUP which can be handled so in > application. The API is already setting rte_errno according to the > reason of the failure. Clarifying this in the spec to list down possible > error codes. > > Fixes: bdce2564dbf7 ("cryptodev: rework session framework") > > Signed-off-by: Anoob Joseph [...] > * @return > * - On success return pointer to sym-session. > - * - On failure returns NULL. > + * - On failure returns NULL and rte_errno is set to the error code. > + * EINVAL on invalid arguments. > + * ENOMEM on memory error for session allocation. > + * ENOTSUP if device doesn't support session configuration. If you don't make bullets, all lines are rendered on the same line, without any separator: " Returns On success return pointer to sym-session. On failure returns NULL and rte_errno is set to the error code. EINVAL on invalid arguments. ENOMEM on memory error for session allocation. ENOTSUP if device doesn't support session configuration. " In general, you must check the HTML rendering of the doc changes. I am fixing while pulling.