From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 965511B35C for ; Fri, 22 Dec 2017 12:38:29 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2AF8620B4F; Fri, 22 Dec 2017 06:38:29 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 22 Dec 2017 06:38:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=06wMUk9TMzVa4HNCNj6kiJCAQk 25cAdzpcxEHxqmdrQ=; b=MOx3PI+dc0u10Z3laSJH8x3OVwd1ccD4GZkgvTSi2F 0V3aUEoTjz5GYh3xiAxHUbziaiR/a1uyG92IGoPbLDrrqg2UrSGs7FlSNIP4/NnN zPnIMkw9tY0hcWWbibkgaAxslnqM52613wTbqrXtzaJ2r2q1Jk4xMkNh1mPlg4vd s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=06wMUk 9TMzVa4HNCNj6kiJCAQk25cAdzpcxEHxqmdrQ=; b=St7jdmZPi2mcOerQy9Bn7H 4Y7xNo7SiHQF3nbd15qY1K3K5VNX24meUb+QPuzbDmbvrCZ/Gff112LO7SWH1Cp2 0RtH8npup12Y9BBcEEnAWjTa3kZK0O8vzRL09w8uwKFHhEoLPSXTNK6QqfsVX1t5 +0xxZu2VUGWkHa9TMp3f+euAervNm4WxmA/sMQCBwOjQEfUUZwF7uLhP35F5saVd QWgnjTcDhvRVPHU+HbPfrlC37LCJTMkDHLLSDGKQ9wOb+3KrXHmBqXoViTf7Lujs h2gdCChaWTRuLrFXoztbxDaprcHJGu63OMIOXzwAYLXckbYs+712mfT3gktYJGpA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BD8642436B; Fri, 22 Dec 2017 06:38:28 -0500 (EST) From: Thomas Monjalon To: Hemant Agrawal Cc: dev@dpdk.org, ferruh.yigit@intel.com Date: Fri, 22 Dec 2017 12:38:27 +0100 Message-ID: <4919393.KhUSbVM1LT@xps> In-Reply-To: <1e293147-9c72-9e77-97cb-9aabc9e5af39@nxp.com> References: <1513922231-15554-1-git-send-email-hemant.agrawal@nxp.com> <2388140.F1AUfV8GGA@xps> <1e293147-9c72-9e77-97cb-9aabc9e5af39@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] Create kern folder for Linux kernel modules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Dec 2017 11:38:29 -0000 22/12/2017 11:04, Hemant Agrawal: > On 12/22/2017 2:13 PM, Thomas Monjalon wrote: > > Hi, > > > > 22/12/2017 06:57, Hemant Agrawal: > >> This patch moves the Linux kernel modules code to a common place. > >> - Separate the kernel module code from user space code. > >> - The GPL-2.0 licensed code is separated from the BSD-3 licensed userspace > >> code > > > > What is the benefit of separate things by license? > > The separation makes it easy to identify and check the license. > > Any patch introducing new file in *non-kern* folders shall not be > GPL-2.0 licensed. Or GPL-2.0 license is allowed only for kern folder. The kernel modules are in DPDK only for historical reasons. We should get rid of them, and rely only on upstream modules. And it should be allowed to have kernel-related files elsewhere. Examples: GPL tools or BPF code. > > These modules are Linux modules, so they should be in the linuxapp dir. > > > This is a cleaner separation w.r.t userspace/kernel space code. > *kern* is a better placefolder for LKMs. I prefer "kernel" name. > Also eal is not getting overloaded. > > linuxapp is part of librte_eal. KNI is not related to EAL, but still > the kni kernel code is added to librte_eal under linuxapp. Yes it makes sense. More opinions/votes? > > There are also some kernel modules in the bsdapp directory. > > We can move them as well.