From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 3003C6CD6 for ; Tue, 13 Sep 2016 21:30:12 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id i130so12573798wmf.0 for ; Tue, 13 Sep 2016 12:30:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=SdpDBjfMeSjbwuubnNIrgFHsX77MHhtXlAfXUY97h18=; b=bJwrC+4RRJpt14kgB2HKcgJd4fFuZuw4XhGt+aPrfw/nEKpJWW2S1aYz25VT9U7nQ5 wzYRcbeL2sHZXFbSPWJOrVhBiOUJjrLwB7YJEurPm6LnFjfeYTGPSLacPA+JLZVtlLuZ BGNJqhDc6L8wE4m7YYOKgdgZST64pZ5Kwlbbe51FSeRmfQg1FP8cuRfxWU8iBKPwOJ/E xd0qitNHZ9qSQDh/HzQU2j1erfqCpEg9aHuiL8ZGUzD/KKnd9DkKc5DqDroc/0KLUdQq qNATmUcE190FRt2BxzaBpKwBSIV5ejwwkbtbRxT8e7ZRP+cJgeg0OQC6n4WnELfUc+pm i9ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=SdpDBjfMeSjbwuubnNIrgFHsX77MHhtXlAfXUY97h18=; b=RqrAnLaqUSLyorQohLyk2UvpKRVjw9wzueGTY9aSswP9wtIQvegwHdpHdxEyeOyAnf doZIc0J1R/lQjYo7FYa3H15FMfBIezoLhkiWrwKW+dKKMw4Z5VYgrKq5nExC8c+CA7sr GwhCdD+JDbEwgOxJJGqTaJ7iF8oQpUjFIKob9/3zNSc9QZpoCFFBOkB/gK4Lbx3CZkuC PrVtKJ2gDg4lef9Q4qEA3HA4KSKo3rrSDAgZoIawgf3hdFiyy1+0nfypFW3cqSwhu516 8FJMUPVQ9DX1PHvwvbp1HICIRozmikOknqUBKdRk33YuLkT4ujSV/e+3gwvFDCPe6Mhq 3GkQ== X-Gm-Message-State: AE9vXwNEO98ZfMFHuLWmjSs2XqVVM5RfH5UIOXHjQRi21xIyKLWOcSOIXIovYX9iSYUa4Bun X-Received: by 10.28.208.130 with SMTP id h124mr2295071wmg.101.1473795011940; Tue, 13 Sep 2016 12:30:11 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id w71sm264445wmw.17.2016.09.13.12.30.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Sep 2016 12:30:10 -0700 (PDT) From: Thomas Monjalon To: Alejandro Lucero Cc: dev@dpdk.org, Ferruh Yigit Date: Tue, 13 Sep 2016 21:30:09 +0200 Message-ID: <4929828.LndqCPGnUK@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <9fbfe918-5a09-46c1-2c85-928fac9d7c0d@intel.com> References: <1471360528-13477-1-git-send-email-alejandro.lucero@netronome.com> <9fbfe918-5a09-46c1-2c85-928fac9d7c0d@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] nfp: using random mac address if not a configured mac X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2016 19:30:12 -0000 2016-09-13 18:10, Ferruh Yigit: > Hi Alejandro, > > On 8/16/2016 4:15 PM, Alejandro Lucero wrote: > > Signed-off-by: Alejandro Lucero > > --- > > There are following checkpatch warnings, also check-git-log complains: > > Headline too long: > nfp: unregister interrupt callback function when closing device Just a tip to keep headlines short: you can often remove some common words. Here we still understand the idea without "function" and "device". nfp: unregister interrupt callback when closing