From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 7728F1DB8 for ; Thu, 28 Mar 2019 23:53:46 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EF04722EA2; Thu, 28 Mar 2019 18:53:45 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 28 Mar 2019 18:53:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=cfWbPc4ubP4M4A+6TUPQv6ejIoPV0iYXdp8uqM6B0bg=; b=nU/0edip9zgs B8y9K4k4c0eWQjIdD/nOfRNbZjjeBZ+kwc6xLebv4yPoTFTk5e0RZ+ipPO9EYazS StVZK1HvFRdQkSlQhFDbhKP5QOp4IpXjXlOu0ySG/BNJHHavKcL7SjO9NrfnBbdD ukITx3LxJd4StX+zlv/70qLA0DiMIdA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=cfWbPc4ubP4M4A+6TUPQv6ejIoPV0iYXdp8uqM6B0 bg=; b=0oxmedDsxxMT/Um6TxGcSA52uda1oXo78TnrDyzjWmKbcJfb0uyvuaA/W h+WLgqhY3p6rHyvDibDnH1ZnCBiPJ4o7xvr5xvbI5KpR47V0ZFYmLkGYktkSstSc kVDLfFRRxuHkX5CvmNP6rlMwAQaDOIfY1eWgWgLDIBprZcJyZZ4fe1/F59+LEeQQ 7FBiXDbQ5YNhclKWmbTDhT1wpLKnqmRPfyjlhOIhh+iRMq0zjIc6Y+fYaqeHyCHr 5FBWVLqlsAJ6TYux0pT9tEkY8bp1gLU0kt03vtnGgRSkPAmppySZFeZ2pqZQMEtb ndvUVEez2j6FQ9CYQ+bxKXGQO9sWg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeehucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofho nhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejje drudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghs sehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 65D07E4383; Thu, 28 Mar 2019 18:53:44 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: Shahaf Shuler , Jan Viktorin , Gavin Hu , Chao Zhu Date: Thu, 28 Mar 2019 23:53:43 +0100 Message-ID: <4937558.DrODiE4unh@xps> In-Reply-To: References: <20190319211601.31983-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: remove redundant API description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Mar 2019 22:53:46 -0000 20/03/2019 07:46, Shahaf Shuler: > Tuesday, March 19, 2019 11:16 PM, Thomas Monjalon: > > Subject: [dpdk-dev] [PATCH] eal: remove redundant API description > > > > Atomic functions are described in doxygen of the file > > lib/librte_eal/common/include/generic/rte_atomic.h > > The copies in arch-specific files are redundant and confuse readers about the > > genericity of the API. > > > > Signed-off-by: Thomas Monjalon > > Acked-by: Shahaf Shuler Applied From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4E180A0679 for ; Thu, 28 Mar 2019 23:53:48 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 731492BFA; Thu, 28 Mar 2019 23:53:47 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 7728F1DB8 for ; Thu, 28 Mar 2019 23:53:46 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EF04722EA2; Thu, 28 Mar 2019 18:53:45 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 28 Mar 2019 18:53:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=cfWbPc4ubP4M4A+6TUPQv6ejIoPV0iYXdp8uqM6B0bg=; b=nU/0edip9zgs B8y9K4k4c0eWQjIdD/nOfRNbZjjeBZ+kwc6xLebv4yPoTFTk5e0RZ+ipPO9EYazS StVZK1HvFRdQkSlQhFDbhKP5QOp4IpXjXlOu0ySG/BNJHHavKcL7SjO9NrfnBbdD ukITx3LxJd4StX+zlv/70qLA0DiMIdA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=cfWbPc4ubP4M4A+6TUPQv6ejIoPV0iYXdp8uqM6B0 bg=; b=0oxmedDsxxMT/Um6TxGcSA52uda1oXo78TnrDyzjWmKbcJfb0uyvuaA/W h+WLgqhY3p6rHyvDibDnH1ZnCBiPJ4o7xvr5xvbI5KpR47V0ZFYmLkGYktkSstSc kVDLfFRRxuHkX5CvmNP6rlMwAQaDOIfY1eWgWgLDIBprZcJyZZ4fe1/F59+LEeQQ 7FBiXDbQ5YNhclKWmbTDhT1wpLKnqmRPfyjlhOIhh+iRMq0zjIc6Y+fYaqeHyCHr 5FBWVLqlsAJ6TYux0pT9tEkY8bp1gLU0kt03vtnGgRSkPAmppySZFeZ2pqZQMEtb ndvUVEez2j6FQ9CYQ+bxKXGQO9sWg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeehucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofho nhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejje drudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghs sehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 65D07E4383; Thu, 28 Mar 2019 18:53:44 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: Shahaf Shuler , Jan Viktorin , Gavin Hu , Chao Zhu Date: Thu, 28 Mar 2019 23:53:43 +0100 Message-ID: <4937558.DrODiE4unh@xps> In-Reply-To: References: <20190319211601.31983-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal: remove redundant API description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190328225343.LCJeWcKc29RWrdZ2BF7PLw9NEHKvKFjP4nkHUpGgVDY@z> 20/03/2019 07:46, Shahaf Shuler: > Tuesday, March 19, 2019 11:16 PM, Thomas Monjalon: > > Subject: [dpdk-dev] [PATCH] eal: remove redundant API description > > > > Atomic functions are described in doxygen of the file > > lib/librte_eal/common/include/generic/rte_atomic.h > > The copies in arch-specific files are redundant and confuse readers about the > > genericity of the API. > > > > Signed-off-by: Thomas Monjalon > > Acked-by: Shahaf Shuler Applied