* [dpdk-dev] [PATCH] eal/bsd: fix config creation
@ 2019-07-12 14:48 Anatoly Burakov
2019-07-12 14:56 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Anatoly Burakov @ 2019-07-12 14:48 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson
The config create function did not store the mem config address in
the shared memconfig structure, so the secondary processes couldn't
map it at the requred address.
Fixes: b149a7064261 ("eal/freebsd: add config reattach in secondary process")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/librte_eal/freebsd/eal/eal.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/lib/librte_eal/freebsd/eal/eal.c b/lib/librte_eal/freebsd/eal/eal.c
index 13ca1202c..d53f0fe69 100644
--- a/lib/librte_eal/freebsd/eal/eal.c
+++ b/lib/librte_eal/freebsd/eal/eal.c
@@ -266,6 +266,11 @@ rte_eal_config_create(void)
memcpy(rte_mem_cfg_addr, &early_mem_config, sizeof(early_mem_config));
rte_config.mem_config = rte_mem_cfg_addr;
+ /* store address of the config in the config itself so that secondary
+ * processes could later map the config into this exact location
+ */
+ rte_config.mem_config->mem_cfg_addr = (uintptr_t) rte_mem_cfg_addr;
+
return 0;
}
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] eal/bsd: fix config creation
2019-07-12 14:48 [dpdk-dev] [PATCH] eal/bsd: fix config creation Anatoly Burakov
@ 2019-07-12 14:56 ` Bruce Richardson
2019-07-14 13:30 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2019-07-12 14:56 UTC (permalink / raw)
To: Anatoly Burakov; +Cc: dev
On Fri, Jul 12, 2019 at 03:48:08PM +0100, Anatoly Burakov wrote:
> The config create function did not store the mem config address in
> the shared memconfig structure, so the secondary processes couldn't
> map it at the requred address.
>
> Fixes: b149a7064261 ("eal/freebsd: add config reattach in secondary process")
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] eal/bsd: fix config creation
2019-07-12 14:56 ` Bruce Richardson
@ 2019-07-14 13:30 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2019-07-14 13:30 UTC (permalink / raw)
To: Anatoly Burakov; +Cc: dev, Bruce Richardson
12/07/2019 16:56, Bruce Richardson:
> On Fri, Jul 12, 2019 at 03:48:08PM +0100, Anatoly Burakov wrote:
> > The config create function did not store the mem config address in
> > the shared memconfig structure, so the secondary processes couldn't
> > map it at the requred address.
> >
> > Fixes: b149a7064261 ("eal/freebsd: add config reattach in secondary process")
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-14 13:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-12 14:48 [dpdk-dev] [PATCH] eal/bsd: fix config creation Anatoly Burakov
2019-07-12 14:56 ` Bruce Richardson
2019-07-14 13:30 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).