From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7DE142457; Sun, 22 Jan 2023 21:51:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BCC8400EF; Sun, 22 Jan 2023 21:51:08 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 56CA2400D4 for ; Sun, 22 Jan 2023 21:51:07 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 7E0B65C0080; Sun, 22 Jan 2023 15:51:06 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 22 Jan 2023 15:51:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1674420666; x= 1674507066; bh=R/UWXSpdM0PrskLb+unhZ9I7QZi9P/FAcfTIxOJCUJo=; b=J lmFil3aDLlQ3pyTyTWOKzfhGkmZM/46cENHIiL838bU1ko3NhS1fvFw55QyyqZx4 oHk6ymmWOxsJjDDPIHnz19x6tmO4pzUyXsZ+8Iuogkvwk/btl+fW3nDKWP1O4esV eafiocjO2e38YM9goGFUMfVG0sMG/LYgleiokGIQ3CJmx+0IV6Ocq/yaWWDG8ASs AeCH7MVFga+scwM6Z+32eQRQZP7mkIAE3rpgvsHLq1OK1QUYrBtKRUZsaeKzHjv3 99WywoedAF0LJD5weD/XDF6+npMCrewa1MWhyZxif36J0rCCxvWmN8ls2tj5cLlj ZPy1LvGqZf6eZU7lseo+A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1674420666; x= 1674507066; bh=R/UWXSpdM0PrskLb+unhZ9I7QZi9P/FAcfTIxOJCUJo=; b=c W51FQxIPwNSGyObRL3d0bdzFs/tAoge8L0HIDwvuzyN02yhHqJxYS8x/YdLVTE/8 CPfRMN2nVUZDGaN6wBYJF2trW5+ZFe2Fx5E+XoCaOE+ecX8dE0N1F6IIEfMHUN0L ZXxQLG0ib+adIJjeeOJuD0rogmIeVyaoCC/7vpEj4GoUgPh3dlJuxSpsAGJ4zgRT abmP5FhD8Adwge5e/sV3bodzAaoxcpi56zhARGm/L+d/gSTvjCotQb8zDFlCIJp0 EStqoINK/b8DK+ffFRD3EOccZAHfXF1p74Lq7uZgoSATqwcafbxYdyJ0u6Qzd2BT Nxu88CpJI9p4ufCjwewmw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudduiedgudeghecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 22 Jan 2023 15:51:04 -0500 (EST) From: Thomas Monjalon To: okaya@kernel.org, Stephen Hemminger Cc: Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org Subject: Re: [PATCH v3 10/10] bus/vdev: check result of rte_vdev_device_name Date: Sun, 22 Jan 2023 21:51:03 +0100 Message-ID: <4942344.1oUyQt6lIG@thomas> In-Reply-To: <20230120084715.18e0fb24@hermes.local> References: <20230120044140.95975-1-okaya@kernel.org> <20230120044140.95975-11-okaya@kernel.org> <20230120084715.18e0fb24@hermes.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 20/01/2023 17:47, Stephen Hemminger: > On Thu, 19 Jan 2023 23:41:40 -0500 > okaya@kernel.org wrote: > > > diff --git a/lib/ethdev/ethdev_vdev.h b/lib/ethdev/ethdev_vdev.h > > index 364f140f91..6d94a65d97 100644 > > --- a/lib/ethdev/ethdev_vdev.h > > +++ b/lib/ethdev/ethdev_vdev.h > > @@ -34,6 +34,8 @@ rte_eth_vdev_allocate(struct rte_vdev_device *dev, size_t private_data_size) > > { > > struct rte_eth_dev *eth_dev; > > const char *name = rte_vdev_device_name(dev); > > + if (name == NULL) > > + return NULL; > > Please add a blank line after declarations and before code. > For some reason the DPDK version of checkpatch suppresses this warning. The check of "name" is related to the line above, so I don't think we should insert a blank line.