From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59A2AA00BE; Thu, 11 Jun 2020 08:11:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AD8112C30; Thu, 11 Jun 2020 08:11:06 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id 745E52C28 for ; Thu, 11 Jun 2020 08:11:05 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 01DA96DD; Thu, 11 Jun 2020 02:11:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 11 Jun 2020 02:11:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= tReSb7GHqmmz8NRqqJGw9BGdursgyOHdJOcrf9bGAnA=; b=JDDMWoj+Ou6wLjvo NsQflk8NgUtN3CiqR6Tdo5DwVRyRnold7mjw69dfUcVqq+IKtslZ6wOQQcv5WyjN 8HpZvoCHV9L1ejEPriWPipgYAWILbc4eHMxQAPOZhDSkIptS0TC0UmfbESPCL37t yEfj7zQWv1XExl34i/4di2Y05oclBbhITNot5yc4xmBJDlwNb5BZWEr3QMrY2mtl Z+OhX/l1893Veu9ySZ63bs8JNB0IfRlQDHmQ6IhxvfT39nHK5wpJFWmGB9LYR0iZ /FCdMthf1TAvkM/qd6tL2LPlzIfd0lRp7FzLTc1+IYa4vcFLHZqh5APPZBUjKipA atFegw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=tReSb7GHqmmz8NRqqJGw9BGdursgyOHdJOcrf9bGA nA=; b=JlFGo8NoU+4MgBLn6zYWd5p7FPCDQCTNNDdcw4UoP0ZSM4U0p45Qyt/aA g+gTTsIapMVLY+4e4OFisGtgKo56dG75xF6XYCFGJjHiU4Q/HyJgH2gNWylaLx0y PSNLz76db4X7UVU4QuLx2j+QNvOQit2aTHcCfgq9dRuCieCLMRj7LpPZr6fJ5EK6 7dHM7y7L2mrQIybWXuqbluZxB/oGTyEGjRXp0iTIasj838+puC0BkyQIl1Ibdhlt gZK3Y0zHzxTeMoZ7wUzfmYy4kkRZbCUDlc5hnn170483OOqDf/jQ6UebPG0X3XbY WRIgx04GJ6jReibubwGB8MLyFjBNg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudehjedguddthecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8D7E23280060; Thu, 11 Jun 2020 02:11:02 -0400 (EDT) From: Thomas Monjalon To: Somnath Kotur , dev@dpdk.org, Olivier Matz , ajit.khaparde@broadcom.com Cc: Ferruh Yigit , Stephen Hemminger Date: Thu, 11 Jun 2020 08:11:01 +0200 Message-ID: <4944852.P50WTChpiv@thomas> In-Reply-To: <4164380.5S5RWRVCr3@thomas> References: <20200106083423.26600-1-somnath.kotur@broadcom.com> <1629576.oqx4rD5t72@thomas> <4164380.5S5RWRVCr3@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mbuf: fix to update documentation of QinQ stripped bit interpretation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Ping Anybody volunteer to make a v2 please? 24/05/2020 17:34, Thomas Monjalon: > Somnath, why neither update, nor reply to reviews after February 7? > It is discouraging for reviewers. > > > 24/04/2020 20:24, Thomas Monjalon: > > Please Somnath, it is waiting for a v2. > > > > > > 26/02/2020 01:55, Stephen Hemminger: > > > On Fri, 7 Feb 2020 15:29:59 +0100 > > > Olivier Matz wrote: > > > > > > > The meaning of each flag should be as simple as possible, I think we can > > > > summarize them like this: > > > > > > > > - PKT_RX_VLAN: the vlan is saved in vlan tci. > > > > - PKT_RX_VLAN_STRIPPED: the vlan hdr is removed from packet data. > > > > - PKT_RX_QINQ: the outer vlan is saved in vlan tci. > > > > - PKT_RX_QINQ_STRIPPED: the inner vlan is stripped from packet data. > > > > - When PKT_RX_QINQ is set, PKT_RX_VLAN* refer to the inner vlan > > > > of initial packet, else it refers to the first vlan of the packet. > > > > > > > > There is a link between vlan flag and vlan_tci field, and qinq flag and > > > > vlan_tci_outer field. > > > > > > > > I'm still not sure to understand what you expect. Can you give an > > > > example with flags (which are set), and the expected content of m->vlan_tci > > > > and m->vlan_tci_outer? > > > > > > > > By the way, the case 5/ is not very well described too, maybe we should > > > > add something about it. > > > > > > > > Thanks, > > > > Olivier > > > > > > The patch does help clarify the meaning, and Oliver's summary clarifies > > > even more. It might be possible for hardware to offload inner vlan but > > > not outer vlan, though seriously doubt anyone but some conformance test > > > would do that.