From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 430AF41D93; Mon, 27 Feb 2023 22:47:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 34AC340A84; Mon, 27 Feb 2023 22:47:12 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2048.outbound.protection.outlook.com [40.107.220.48]) by mails.dpdk.org (Postfix) with ESMTP id 4198940A7D for ; Mon, 27 Feb 2023 22:47:11 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FJxavA1yseagc408sRAunPA+1Q8E+D2eD2//gjeVeOPWtuW2wjTxRS0Rvhfrvl3jBGdKe2jRyhrjr2uyOQCVC5hj37CFZaxuFhZmMBJGa89xwQwLFx2ByEU+Zo6cTaXINpdm9haR034DlZXpbLyqzrXBiFLNWic42Lj+F7X36loUPMPNamJFqL0/UG0pZPLg0Bmeb0Ovi7TTZpD11SxNr5b/+iYSuZlD5R4NbFoejDpfQS/uMThJmuZ9Q+E7/7GX6heLQ9pOXAFkDvTvXrz+SlC4LCd2hrwEhWk9uq2+GYebgoWgZOdct1P7EeU3h6H3gyA6ax2XgycgeDXzDNb5zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZAhLm54GO3WUkU5Pg3MEzb57Ts1hv/WeSj/dsu9ORb8=; b=jT1QyT+hlPCoheZA7egANe+0NcNAu8qmtJryLWVG9AmClZaw5nD8/9Rc8Jf5JADVAyZvgKM+RPPIQe8OG56EOQadx9St4l1Nv/MbGfZmjRiZ1y2S8MAE/X2ACLiv62fce6pzQcxwqwo6KlTJfc+KXRrFpYvhr15lfm0dNJB9W8PD49CGqoljsjuFI9FIWKu44mrgVilSbtTm8bexgHE7tuNe7L3FlEsU3BBXYu9AXsyfDdm5sqSVCCmzcOTD3EeJdpnBV4TRF6FxQ6yBDwHq9ii1Sgb3689IG8OR1X6t+JZvIHSDNCHRWHEDHCSsaKfXlu4vUgBwWXefRupNllGTBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZAhLm54GO3WUkU5Pg3MEzb57Ts1hv/WeSj/dsu9ORb8=; b=1Zvtue4g8SHKoElnjKViUV+7Z3GuAFX4kwpeExPN21qmu0PDBMV20XladW2oPd8cRltEp9QrFmlowZsH3IpKqAkldrbXL4yxWPibb5tj0UGHrTw4hPnkF92JPR4WieNBs8n5m6dSa2kusQo/5NmsGXphgXIxGmpsYwMwkL63e3o= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH8PR12MB7280.namprd12.prod.outlook.com (2603:10b6:510:220::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.25; Mon, 27 Feb 2023 21:47:09 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%7]) with mapi id 15.20.6134.029; Mon, 27 Feb 2023 21:47:09 +0000 Message-ID: <494a2ec6-8e02-bc29-9ad2-c570a82fc233@amd.com> Date: Mon, 27 Feb 2023 21:47:03 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Mingxia Liu , dev@dpdk.org, beilei.xing@intel.com, yuying.zhang@intel.com References: <20230213021956.2953088-1-mingxia.liu@intel.com> <20230216003010.3439881-1-mingxia.liu@intel.com> <20230216003010.3439881-6-mingxia.liu@intel.com> From: Ferruh Yigit Subject: Re: [PATCH v7 05/21] net/cpfl: support queue start In-Reply-To: <20230216003010.3439881-6-mingxia.liu@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0435.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::8) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH8PR12MB7280:EE_ X-MS-Office365-Filtering-Correlation-Id: a7d85c1f-f548-49ce-75d4-08db190c2d41 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GJCBAvpSfOu4V+Zp7EZAZuwPIHcJvKFPxyH+/zdUpYIFoodywNUt4RP07J836XZaauNmeYu61HJSMdNHKXVqbIdQa7NxpPhwbBuWVCUB1eCp8pZv/haq2VC4m59HugI8fNN/7+IiLG5Rr0KXrrFtLGYvxZrTrMVyx4RezNgFXGH47IeaFR51Mh9SWnwxxzWlT9YX2+SQjN6Y7Y/ER6rFxsr5pZqo0aHiuMCeWpw6bUyziE0w9y3HfVu2LzAfFzSaZi3cEmNkc4oa7Zj5feyieISgHYHFhxyuBeFBBx26Ao0BKdZnLeYTjVbHzRRU57DUtPLuXH5Cng5EcgwTlzDTVJNebHqG3l5YRHaZNVP3dlB09Rvoocgh5Q6beGmTboaur74TS6l5nq34cFfZ24q/BU9PZnC2Gq0Bkm+dhlapXroBOHISSXfDZydPulNQ4Fnd4uLS7LYxx80iwJlf4WbM1QtqOu1EsCb2n6BvIdIIb0puWFVBHtIxVfyyywQHo8kxqWLSvGy0uivjxMju952MnmDijfKSlCqZqzOKb5BBJVVEK5AVSleDL+lq4EyibEVeTYRr/o06hoVkBrRiQ8iWxbdKDApXAcH4xYn3NsoAbFJsuW7ySRr7I4GeGX6wf+MD/AGSCUZnYm8/DO/R452f5D8dqYot3aISbpqMCjNGtIdBCxhUV1sl/oeNkLJJdT9myTV3jFRda9iZv9y3HHtOOvPwO+6oeh734Pz7tU1fT54= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(136003)(396003)(39860400002)(366004)(346002)(376002)(451199018)(186003)(38100700002)(41300700001)(8936002)(66556008)(66946007)(8676002)(2906002)(4744005)(66476007)(6506007)(6512007)(44832011)(53546011)(2616005)(478600001)(26005)(31686004)(31696002)(5660300002)(36756003)(86362001)(6666004)(316002)(6486002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzdDVUF4L0JsQWFuZGZIZElxc3h6UHNWUTNuRmRMUGh5c2tPOVNDRS9DUVpa?= =?utf-8?B?L2dHNXNtL2ttaStZYmV3SmYwSHZTSXF4WEJRaHprdGk4QWxCdnpVR21LYnJ5?= =?utf-8?B?M1RlYzJOUkNzeEF4aS8weEtCNFI1Ylk1WDFlZHFiSmFRc25Wd2Urb2xSVGht?= =?utf-8?B?OVhnbXk2OFl3d3U3NzBFa0Nuekx3dFJNQVBHRWd1RjBwK3NQWENqK0ZpWVRn?= =?utf-8?B?eEZIbjJBbkxINXA4S2lWSi9SWTc0K25mRzRnMWhBWFdzUk5XQS81OXc0OGRN?= =?utf-8?B?RkVuSkJub2VPd3FjS0FtaDdZcGpxTmNkYXdHcEJGZjFFYi9hYmNsVVlVKzNX?= =?utf-8?B?d1k0aisrK0lrRjJhZFdlNXJXN2l2a1o1bVFYQ2dBS0VOU0ZYRFZkVGcxa29F?= =?utf-8?B?bEh5L1VNM2dDOHIxNTFvcUtreWNXRU5VTUZyT2o2bWNXTE9nWm54OWdWbVJB?= =?utf-8?B?U1hOZEhUUktaK25vOFEveVNISGptbzdSU3FJSDdzM1Y0OGQ4NGZFRFhrcURF?= =?utf-8?B?Qy9NaXF1N0hmT1o5c1Q2a0hjZkVKRmJMdGtSWW1ZODI4VHdrVzRnTjJILzFW?= =?utf-8?B?ZnFiQXRCajU5aTAvMSs2QjcwdGczOVk4YWltYnhSakdSN24wOXZBZ1Q3aUsz?= =?utf-8?B?ZW1rTm53eFZObUFkWURtcTdFR214YXJpNmlSVW85NDYwbWNjY0g0bWs5NG9D?= =?utf-8?B?dFlrSEVTRjVIcCtFSFZiQjBwTC9pVWc4ZFd0RUFhWWJVZm9TRXJOaEpGQ0hG?= =?utf-8?B?eFVhd1B0eTZzS1E1K3BsSHkzSkZxSXZ6cjhBNEhEYnZZdTFCU3BsTmJ5N2dU?= =?utf-8?B?UFNqaDgxTVFIbHBaaWpGUXhweTEySEU1bmZjbmZwUmU1dFhEYzY4YXR5enY3?= =?utf-8?B?a3g2UmIyd0hiUE5BamFNbFZRVWY1MVRBYnFmSkt3Mlc3OHNWYTJ3YU9mWUc5?= =?utf-8?B?M2V4QmRQbVZ2Wnl6Zkg0aXBsWHRZU2E5OXZ0WmR4MUhKU1hSSkZpVDRJcDJ6?= =?utf-8?B?VXRxcjVabFBiVVlVazRFVVVjaHZraDM4K2lGTmdkZTV5K3lrTE9oeDlDMXNn?= =?utf-8?B?N3ZUNm83RWtBWFVOaVpQaCtQUVR3bktuWXNacXRGUXFSbXdpTlhNMS9odXpm?= =?utf-8?B?TVJ6bUdZTEpVM3ZDUXJweS9PWG90cDFpckJaYnNFUk4rMlZ2WXM0K20ycEgw?= =?utf-8?B?cmNDRGdOamN1amF5Q0Q4VmtWT1hSSU42cHRyWlZNQ0tINGtKMkxVQkNJaXJ1?= =?utf-8?B?R3piYjVHS1JZZGc4QjNrbVZhcmh3SXFmUXIrWUZnVzY0TzJwT2RING1GcHFk?= =?utf-8?B?ZW1nOWNiaUwzSEk2TW1rajZwTEpET0V4KzI1a25kUGw5VVJ2VnJMQ2djOVBw?= =?utf-8?B?dFpLUVVPdGNjbFYrbGNXT2NXaXk5RlhjbEFVdG4vcFN4V2FqNy9POGZZOEVR?= =?utf-8?B?c2g1YzRYRXZpbVRoMWswcnFudmtOekxFbVFyNkJycHhrRjNXc0VVQ01rVmtz?= =?utf-8?B?dDMrRldpa05KQ0ROWE8ydjYvZ3hIeFYzUlh4OWF4dS9KTENLYUZqSE43UDJL?= =?utf-8?B?WVU5VWxTQ3IxVWNCQlJWcnNEbVVOVXlJRFQ3WWJMY1lwNUsreWZqM0R5VjdX?= =?utf-8?B?NmppWVJmWXlpZkhYMHMzRDgwZ0VHSW9KejhKcVRSMWJrMDZaS2x1ZUZJL3Uy?= =?utf-8?B?ZDV5NW9UczVSeDZWQmdGdnlMMkZKbVordFJWUG9NUDhNaFdxUXA2ZzIxSnJl?= =?utf-8?B?RzVMT1NLTUp5Ymk0bTVpZHZtaGZUK1ZZcWRtTEJzeWZZem9XRVQxbGYwblY3?= =?utf-8?B?SjBnZEkvL1FNOXNkc1VCRWQyVVhJS0MwSC94Qk1SemN1ZENVclZZUnNXSUlU?= =?utf-8?B?aEFvV0lXUkhaTG5yMVhZMlRkU0V0YVBVSE50RGpxYzVEcWg3MkFzNlJ1TFBX?= =?utf-8?B?MkhvaytTM1lpZmRSZzhZOU1Sb1I0Y3kwS05TcTBRSmZHcUxOM2crdmRHSHIy?= =?utf-8?B?ZzJrWkI4WFEvMmgzR3hoc1RqT1ZwQk1RaWNsZHVLcWhzNkhqVWZvRTlpRzhT?= =?utf-8?B?bU9ZMEF1eGNJcUVRM3ZGYVZRRXJPRDNzVHRwbVNJSWlDVE9xUkozQ3hVcVZi?= =?utf-8?Q?lU3wYq4ME3eEy+sTRGBIMriyf?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7d85c1f-f548-49ce-75d4-08db190c2d41 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 21:47:09.4810 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AXCSQnBBtYZdeXsPZBPTAY5XCILnZWQe/H+3rkowMa+DdRWltPjN0K4Karww7Uix X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7280 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/16/2023 12:29 AM, Mingxia Liu wrote: > Add support for these device ops: > - rx_queue_start > - tx_queue_start > > Signed-off-by: Mingxia Liu <...> > +int > +cpfl_rx_queue_init(struct rte_eth_dev *dev, uint16_t rx_queue_id) > +{ > + struct idpf_rx_queue *rxq; > + int err; > + > + if (rx_queue_id >= dev->data->nb_rx_queues) > + return -EINVAL; > + > + rxq = dev->data->rx_queues[rx_queue_id]; > + > + if (rxq == NULL || !rxq->q_set) { > + PMD_DRV_LOG(ERR, "RX queue %u not available or setup", > + rx_queue_id); > + return -EINVAL; > + } > + > + if (rxq->bufq1 == NULL) { > + /* Single queue */ What do you think to keep the queue type explicitly in the queue struct, instead of deducing it from pointer values?