From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0255BA04B1; Thu, 24 Sep 2020 00:36:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A32E01DB10; Thu, 24 Sep 2020 00:36:12 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 35CDE1D656 for ; Thu, 24 Sep 2020 00:36:11 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id A6B725805A9; Wed, 23 Sep 2020 18:36:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 23 Sep 2020 18:36:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 1xFWc7E3igSLVAfxKjjihW8JYP8IPeeVD9DTrenxAk8=; b=N6E9igHOxI6S0RAe twMrQhOBDqN/yu7tFyNo9jYCZAQfDQhdv599LatPAzp/YD9jbFggki4+GD6THssv EHIhYHMNHk0dHGEv6yVHq6nskI3Mw2OYa5TRUP2wRJolbywdLadlxPI1AKBDUHVB Rmb79Yz3NXy6iV6MfKt9/0et9pKD2m9l1SdUbeq7igy8aQSnFvrMoDxXAQn+3369 vAmODhpCspHrn4FLYLlXh07rZWneiPkc/JR+dpLYLsb9t08/KegVQlBMuPuj83BQ aJHZ8ds1jUPbza3YHwGw6Gk2zYWyUf8GhudobPsJDIIHY8HCXEaACKExpnuVJCQH jDHluw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=1xFWc7E3igSLVAfxKjjihW8JYP8IPeeVD9DTrenxA k8=; b=BVLSlS2vSpPWdYxKbhP1T1711Sz80dxGtm6rP4Zaukf5EiWnmT1g8Q6Kw VdVoAokfxC5+FMarLEA3i4O9EL+G/phlg+eHvYA1mE1NpthNfBGjmzd8UcGEbI9n oOEwuzMmiJNG5jB8BHn5pnaDZcwDzDi3oOnGO4K8qkR/1omp4l8RmhD5G+fg8qrM jg1JbBHHxwmzbusuMnpLja4WuBlGhHpnBdx8n2Zu06vf2D6E0ytK1jDJ7Zt0E2W1 rGC/UJT4I1m2XjWsBuZpFsl1Nd9pLy01vriiJQMo+DzZn/aKOkA/dZLBwKVd0J07 7JfRsmc8AIWTFxFtD7oRm595nImOA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudejgddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E80A1306467E; Wed, 23 Sep 2020 18:35:59 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: Ferruh Yigit , dev@dpdk.org, arybchenko@solarflare.com, "John W. Linville" , Ciara Loftus , Qi Zhang , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Steven Webster , Matt Peters , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , Somnath Kotur , Chas Williams , "Wei Hu (Xavier)" , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Wei Zhao , Jeff Guo , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , John Daley , Hyong Youb Kim , Gaetan Rivet , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , Yisen Zhuang , Beilei Xing , Jingjing Wu , Qiming Yang , Alfredo Cardigliano , Rosen Xu , Shijith Thotton , Srisivasubramanian Srinivasan , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Martin Spinler , Heinrich Kuhn , Harman Kalra , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Akhil Goyal , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , Maciej Czekaj , Maxime Coquelin , Chenbo Xia , Zhihong Wang , Yong Wang Date: Thu, 24 Sep 2020 00:35:58 +0200 Message-ID: <4950952.GUjYEhNGMI@thomas> In-Reply-To: <20200923150238.01cbf109@hermes.lan> References: <20200913220711.3768597-1-thomas@monjalon.net> <7906978.WFKINk0of7@thomas> <20200923150238.01cbf109@hermes.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/09/2020 00:02, Stephen Hemminger: > On Wed, 23 Sep 2020 23:52:07 +0200 > Thomas Monjalon wrote: > > > > > > > Yes it is a step in the right direction. > > > > > > Changing the API means adding some error checks in every apps. > > > > > > The reason for not doing is that I did not commit for this task, > > > > > > and I am not the author of the deprecation notice. > > > > > > We can discuss how to follow up once this series is merged. > > > > > > > > > > Not sure what application can really do if dev_close fails other than call rte_exit()? > > > > > > > > At least, it can show a message to the user. > > > > > > Agree, but no code checks return from close() system call now. > > > At least testpmd should be updated; the examples are fine. > > > > How do you explicitly silence the static code analyzers? > > Do you recommend adding (void) in front of the call to close()? > > Coverity usually gives something like, "return value of foo() is not checked > but checked 10 other places" Yes so it should be silenced with (void) or ret =