From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, shperetz@nvidia.com,
"Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [PATCH] mbuf: fix build failure if MBUF_HISTORY_DEBUG enabled
Date: Sat, 25 Oct 2025 08:59:31 +0200 [thread overview]
Message-ID: <4952662.Fh7cpCN91P@thomas> (raw)
In-Reply-To: <20251024222946.323662-1-stephen@networkplumber.org>
25/10/2025 00:29, Stephen Hemminger:
> Message had extra newline which causes build failure.
>
> ../lib/mbuf/mbuf_history.c: In function ‘rte_mbuf_history_init’:
> ../lib/log/rte_log.h:364:9: error: static assertion failed: "This log format string contains a \\n"
> 364 | static_assert(!__builtin_strchr(fmt, '\n'), \
> | ^~~~~~~~~~~~~
> ../lib/log/rte_log.h:387:9: note: in expansion of macro ‘RTE_LOG_CHECK_NO_NEWLINE’
> 387 | RTE_LOG_CHECK_NO_NEWLINE(RTE_FMT_HEAD(__VA_ARGS__ ,)); \
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> ../lib/mbuf/mbuf_log.h:8:9: note: in expansion of macro ‘RTE_LOG_LINE’
> 8 | RTE_LOG_LINE(level, MBUF, "" __VA_ARGS__)
> | ^~~~~~~~~~~~
> ../lib/mbuf/mbuf_history.c:219:17: note: in expansion of macro ‘MBUF_LOG’
> 219 | MBUF_LOG(ERR, "Failed to register mbuf history dynamic field: %s\n",
> |
This check is enabled only with GCC.
Unfortunately I was testing this feature with clang, so I missed it.
Updated commit title:
mbuf: fix build with GCC and history debug enabled
> Fixes: d265a24a32a4 ("mbuf: record mbuf operations history")
> Cc: shperetz@nvidia.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied, thanks.
prev parent reply other threads:[~2025-10-25 6:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 22:29 Stephen Hemminger
2025-10-25 6:59 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4952662.Fh7cpCN91P@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=shperetz@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).