From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 03776200 for ; Fri, 8 Dec 2017 22:04:26 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Dec 2017 13:04:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,379,1508828400"; d="scan'208";a="10914017" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.68]) ([10.241.225.68]) by fmsmga004.fm.intel.com with ESMTP; 08 Dec 2017 13:04:25 -0800 To: Ravi Kumar , dev@dpdk.org References: <1512047472-118050-1-git-send-email-Ravi1.kumar@amd.com> From: Ferruh Yigit Message-ID: <49533283-4355-4544-15e8-4c3308f1ba94@intel.com> Date: Fri, 8 Dec 2017 13:04:25 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1512047472-118050-1-git-send-email-Ravi1.kumar@amd.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 01/16] net/axgbe: add minimal dev init and uninit support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2017 21:04:27 -0000 On 11/30/2017 5:10 AM, Ravi Kumar wrote: > Signed-off-by: Ravi Kumar <...> > + /* > + * For secondary processes, we don't initialise any further as primary > + * has already done this work. > + */ > + if (rte_eal_process_type() != RTE_PROC_PRIMARY) { > + PMD_DRV_LOG(ERR, "SECONDARY PROCCESS NOT SUPPORTED"); > + return -EINVAL; Do you want to return error here? rte_eth_dev_pci_generic_probe() already calls rte_eth_dev_attach_secondary(), just returning here can work for secondary process. > + } > + pci_dev = RTE_DEV_TO_PCI(eth_dev->device); > + pdata->pci_dev = pci_dev; > + rte_eth_copy_pci_info(eth_dev, pci_dev); rte_eth_copy_pci_info() already called by rte_eth_dev_pci_generic_probe() <...> > + eth_dev->dev_ops = NULL; > + eth_dev->rx_pkt_burst = NULL; > + eth_dev->tx_pkt_burst = NULL; > + > + /*Clear macaddres at time of dev init*/ > + eth_dev->data->mac_addrs = NULL; > + eth_dev->data->hash_mac_addrs = NULL; None of these set yet, you can add these when they are initiazed, and this helps to trace matching init / unints. <...> > +#define PMD_INIT_LOG(level, fmt, args...) \ > + RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ##args) Can you please swith this to dynamic logging, currently only i40e has sample usage for it. <...> > @@ -0,0 +1,4 @@ > +DPDK_17.11 { DPDK_18.02 <...>