From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 7AC5E1B143
 for <dev@dpdk.org>; Thu, 18 Oct 2018 19:06:09 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 23F1E22A25;
 Thu, 18 Oct 2018 13:06:09 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Thu, 18 Oct 2018 13:06:09 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=xZ1WMtB0g1YcquYSyBfJhHwmHQu6iLMQ2SsZpLT7UNI=; b=fbikD9lA07rR
 WsesaDd4mCr6427wx/bOrfFpNREBVeR0icf9RIFhyN1hpOy8EFgos/1c3j2aQBMc
 YCNsybw08yAnmY8X9WpxYMkm3GthEnuLmqYHoXAG+SFVQw+MDJNuZNsSIGplpkTr
 Ga11bpHGe885Ino/+CKqbEJIQK/xRVo=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=xZ1WMtB0g1YcquYSyBfJhHwmHQu6iLMQ2SsZpLT7U
 NI=; b=ODiFU8jLGeIIWqJepTYFYU5LZMnj9QaT9c01z7dQee4KnU6RF2Oe7wzSK
 FSVuxfdmhhWsrM3nBNn2ndIm3jJmTOQ6Ncj3Y5annQK4C2UFlyvivLuL9X07hTD8
 mC8DKvbJNM3vgetyp86AG+nySprokuNhQhZ5+lmmZqbxslPa8rIYYyQlc9zCGyqP
 kccHxkfS493Ge4mj+GDhNvi1kdn9hv4U7Js1Bw0SiRyoPuk5/rSk9qEXWeB1xRa0
 srwRflIZDVheToxYS4OnBWJmvmA6HoEPda9flRJjCKFd5XpuWBMb74HlbNKKiJQz
 kX120h6aauYiMniL/BvErJ/iIfbeg==
X-ME-Sender: <xms:gL3IW-q8PM4xFckGBjeG9K6VGjCmXfvThLf6r0UHEhg_PI807eIlPA>
X-ME-Proxy: <xmx:gL3IW6WGWlFbMMpcF0h-NYEgjLD7DP1T--CwnDFx7CTQUzCJ_ms_2A>
 <xmx:gL3IW8EoKnUwScp7zA55Ud-ZYrwtLZvu0cQIyL81-4nRq4crFVYjmA>
 <xmx:gL3IW9eRe95KhagzoY0bU5CO1Z_a_m57mck3c9uoa2lTXRhPPgGD7g>
 <xmx:gL3IW1pQcW3lC9OizsZL2Ql8BBBQwoUBdtTPCxEEfjuUDAvlqQOgVQ>
 <xmx:gL3IW-CQ0thlyMr5sd1pU-qmRPB_9WJeLw1bAE9qqv7FMwcYBJ-_iA>
 <xmx:gb3IW9a1se4qzwVUg7DRLlFJrJTVd0v55UWJTioiXQPZni63HUUDCA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 7B6AB102F4;
 Thu, 18 Oct 2018 13:06:07 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 "arybchenko@solarflare.com" <arybchenko@solarflare.com>,
 "ophirmu@mellanox.com" <ophirmu@mellanox.com>,
 "rahul.lakkireddy@chelsio.com" <rahul.lakkireddy@chelsio.com>,
 Wisam Jaddo <wisamm@mellanox.com>
Date: Thu, 18 Oct 2018 19:06:11 +0200
Message-ID: <49681498.CPYSGzZmHV@xps>
In-Reply-To: <8CEF83825BEC744B83065625E567D7C260D12F43@IRSMSX107.ger.corp.intel.com>
References: <20180907233929.21950-1-thomas@monjalon.net>
 <4688337.PUasVPICMu@xps>
 <8CEF83825BEC744B83065625E567D7C260D12F43@IRSMSX107.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v5 1/6] app/testpmd: fix ports list after
	removing several at once
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Oct 2018 17:06:09 -0000

18/10/2018 18:42, Iremonger, Bernard:
> Hi Thomas,
> 
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 18/10/2018 13:41, Iremonger, Bernard:
> > > Hi Thomas
> > >
> > > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > > 18/10/2018 12:40, Iremonger, Bernard:
> > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > > > >
> > > > > > From: Wisam Jaddo <wisamm@mellanox.com>
> > > > > >
> > > > > > When detaching a port, the full rte_device is removed.
> > > > > > If the rte_device was hosting several ports, the testpmd list of
> > > > > > ports must be updated for multiple removals.
> > > > >
> > > > > ./devtools/check-git-log.sh -1
> > > > > Missing 'Fixes' tag:
> > > > >         app/testpmd: fix ports list after removing several at once
> > > >
> > > > I think it is OK.
> > > > It is fixing a case which was not tested before.
> > > > And we don't really need to backport it.
> > >
> > > If "fix" is removed from the commit message then the fixes line will not be
> > needed.
> > > However if it is a real fix, then I think fixes line should be added .
> > 
> > I know, I am the one implementing this check :-) If I add a Fixes: line, it will warn
> > about a lack of Cc:stable.
> > But we don't need to backport this.
> > That's why I think we can ignore this warning.
> > 
> > Reminder: it is just warning, not a mandatory requirement.
> > 
> > 
> As this does not seem to be a normal "fix", how about replacing "fix" with something like "update", then there will be no warning to ignore.
> Better not have warnings.

Yes, I thought about it and felt that "update" would not have the same meaning.
If nobody has a better idea, I will replace with "update" instead of "fix".