DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: fix lib filtering
Date: Thu, 06 Apr 2017 16:48:11 +0200	[thread overview]
Message-ID: <497164429.X1217vCfaY@xps13> (raw)
In-Reply-To: <20170406141455.14894-1-olivier.matz@6wind.com>

2017-04-06 16:14, Olivier Matz:
> I get the following error when linking the test application:
>   build/lib/librte_pmd_thunderx_nicvf.a(nicvf_hw.o):
>   In function `nicvf_qsize_regbit':
>   drivers/net/thunderx/base/nicvf_hw.c:451: undefined reference to `log2'
>   build/lib/librte_pmd_thunderx_nicvf.a(nicvf_hw.o):
>   In function `nicvf_rss_reta_update':
>   drivers/net/thunderx/base/nicvf_hw.c:804: undefined reference to `log2'
>   build/lib/librte_pmd_thunderx_nicvf.a(nicvf_hw.o):
>   In function `nicvf_rss_reta_query':
>   drivers/net/thunderx/base/nicvf_hw.c:825: undefined reference to `log2'
> 
> While I don't know why it does not happen for a default build, the error
> can be explained. The link command line is:
> 
>    gcc -o test ... *.o ... -Wl,-lm ... -Wl,-lrte_pmd_thunderx_nicvf ...
> 
> rte_pmd_thunderx_nicvf needs the math library, and it should be
> added after. This is not the case because the test application also
> adds the math library.
> 
> The makefile already filters the libraries, but it keeps the first
> occurrence of the lib. Instead, the last one should be kept.
> 
> Fixes: edf4d331dcdb ("mk: eliminate duplicates from libraries list")
> 
> Cc: stable@dpdk.org
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

It is a really nice Makefile recursive function :)

> +# all the words except the first one
> +allbutfirst = $(wordlist 2,$(words $(1)),$(1))
> +
> +# Eliminate duplicates without sorting, only keep the last occurrence
> +filter-libs = \
> +	$(if $(1),$(strip\
> +		$(if \
> +			$(and \
> +				$(filter $(firstword $(1)),$(call allbutfirst,$(1))),\
> +				$(filter -l%,$(firstword $(1)))),\
> +			,\
> +			$(firstword $(1))) \
> +		$(call filter-libs,$(call allbutfirst,$(1)))))
> +
> +LDLIBS := $(call filter-libs,$(LDLIBS))

Applied, thanks

  reply	other threads:[~2017-04-06 14:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-06 14:14 Olivier Matz
2017-04-06 14:48 ` Thomas Monjalon [this message]
2017-04-06 16:20   ` Bruce Richardson
2017-04-06 16:25     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=497164429.X1217vCfaY@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).