From: "Dai, Wei" <wei.dai@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] app/test: remove large lpm test head file
Date: Wed, 28 Sep 2016 15:19:24 +0000 [thread overview]
Message-ID: <49759EB36A64CF4892C1AFEC9231E8D63A2D114A@PGSMSX106.gar.corp.intel.com> (raw)
In-Reply-To: <20160928084154.GA43788@bricha3-MOBL3>
> -----Original Message-----
> From: Richardson, Bruce
> Sent: Wednesday, September 28, 2016 4:42 PM
> To: Dai, Wei <wei.dai@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v2] app/test: remove large lpm test head file
>
> On Wed, Sep 28, 2016 at 01:38:27AM +0800, Wei Dai wrote:
> > remove the large file app/test/test_lpm_routes.h and add codes to
> > auto-generate similar large route rule talbe which keeps same depth
> > and IP class distribution as previous one in test_lpm_routes.h .
> > With the rule table auto-generated at run time, the performance of
> > looking up keep similar to that from pervious constant talbe.
> >
> > Signed-off-by: Wei Dai <wei.dai@intel.com>
> > ---
>
> Can you perhaps indicate what has changed between v1 and v2, it helps those
> of us looking to review the patch. [The best way to do so is to place details of
> diffs in each version underneath the cut line "---".]
---
Changes between v2 and v1 include:
1. add more annotations to explain why and how the data structures and algorithm
are designed.
2. simplify the implementation of same algorithm by removing fields total, left, abc[ ]
in struct route_rule_count.
>
> Regards,
> /Bruce
next prev parent reply other threads:[~2016-09-28 15:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 9:37 [dpdk-dev] [PATCH] " Wei Dai
2016-09-26 9:56 ` Thomas Monjalon
2016-09-26 13:07 ` Dai, Wei
2016-09-26 10:06 ` Bruce Richardson
2016-09-26 13:49 ` Dai, Wei
2016-09-27 17:38 ` [dpdk-dev] [PATCH v2] " Wei Dai
2016-09-28 8:41 ` Bruce Richardson
2016-09-28 15:19 ` Dai, Wei [this message]
2016-10-13 13:28 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49759EB36A64CF4892C1AFEC9231E8D63A2D114A@PGSMSX106.gar.corp.intel.com \
--to=wei.dai@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).