From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wei.dai@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 266CF2A07
 for <dev@dpdk.org>; Wed, 28 Sep 2016 17:19:28 +0200 (CEST)
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by fmsmga102.fm.intel.com with ESMTP; 28 Sep 2016 08:19:27 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,410,1470726000"; d="scan'208";a="14247509"
Received: from kmsmsx154.gar.corp.intel.com ([172.21.73.14])
 by orsmga005.jf.intel.com with ESMTP; 28 Sep 2016 08:19:25 -0700
Received: from pgsmsx106.gar.corp.intel.com ([169.254.9.133]) by
 KMSMSX154.gar.corp.intel.com ([169.254.12.140]) with mapi id 14.03.0248.002;
 Wed, 28 Sep 2016 23:19:24 +0800
From: "Dai, Wei" <wei.dai@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v2] app/test: remove large lpm test head file
Thread-Index: AQHSGOYt6spcir5h9UCxcH+anjVJp6COEGyAgADzeVA=
Date: Wed, 28 Sep 2016 15:19:24 +0000
Message-ID: <49759EB36A64CF4892C1AFEC9231E8D63A2D114A@PGSMSX106.gar.corp.intel.com>
References: <1474882625-67916-1-git-send-email-wei.dai@intel.com>
 <1474997907-24982-1-git-send-email-wei.dai@intel.com>
 <20160928084154.GA43788@bricha3-MOBL3>
In-Reply-To: <20160928084154.GA43788@bricha3-MOBL3>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjg3NmE3NzQtNWJjZS00NzQyLWFkY2EtY2FiY2JkZjYzNmFiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkF4MXV3dDZDSHozakxYWHRHWnRcL0RJQXpFMVdYMVYwWjZcL0lnU3lcLzNmUW89In0=
x-ctpclassification: CTP_IC
x-originating-ip: [172.30.20.205]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] app/test: remove large lpm test head file
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Sep 2016 15:19:28 -0000

> -----Original Message-----
> From: Richardson, Bruce
> Sent: Wednesday, September 28, 2016 4:42 PM
> To: Dai, Wei <wei.dai@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v2] app/test: remove large lpm test head file
>=20
> On Wed, Sep 28, 2016 at 01:38:27AM +0800, Wei Dai wrote:
> > remove the large file app/test/test_lpm_routes.h and add codes to
> > auto-generate similar large route rule talbe which keeps same depth
> > and IP class distribution as previous one in test_lpm_routes.h .
> > With the rule table auto-generated at run time, the performance of
> > looking up keep similar to that from pervious constant talbe.
> >
> > Signed-off-by: Wei Dai <wei.dai@intel.com>
> > ---
>=20
> Can you perhaps indicate what has changed between v1 and v2, it helps tho=
se
> of us looking to review the patch. [The best way to do so is to place det=
ails of
> diffs in each version underneath the cut line "---".]

---
Changes between v2 and v1 include:
1. add more annotations to explain why and how the data structures and algo=
rithm
  are designed.
2. simplify the implementation of same algorithm by removing fields total, =
left, abc[ ]=20
  in struct route_rule_count.=20

>=20
> Regards,
> /Bruce