From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 76092B62 for ; Wed, 2 Nov 2016 09:28:41 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP; 02 Nov 2016 01:28:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,583,1473145200"; d="scan'208";a="186655908" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by fmsmga004.fm.intel.com with ESMTP; 02 Nov 2016 01:28:38 -0700 Received: from pgsmsx106.gar.corp.intel.com ([169.254.9.114]) by PGSMSX101.gar.corp.intel.com ([169.254.1.76]) with mapi id 14.03.0248.002; Wed, 2 Nov 2016 16:28:38 +0800 From: "Dai, Wei" To: Thomas Monjalon , "Mcnamara, John" , "Ananyev, Konstantin" , "Wu, Jingjing" , "Zhang, Helin" , "Dai, Wei" , "Curran, Greg" Thread-Topic: [dpdk-dev] [PATCH] ethdev: fix statistics description Thread-Index: AQHR/4HlmfZn494r80Kdl42es4GFbqCXv+aAgC4ANUA= Date: Wed, 2 Nov 2016 08:28:37 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D63A2EB13C@PGSMSX106.gar.corp.intel.com> References: <1472206104-22035-1-git-send-email-wei.dai@intel.com> <2544827.v0ahXV4zxG@xps13> In-Reply-To: <2544827.v0ahXV4zxG@xps13> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDE3MmYwYzYtN2EyYy00YWNlLWExNDQtYjljOTlkNzk0NTFjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjhwVlY5Q2ZWU1N0SFN6emVCbU56SndaeWo1SHR2MlNjaUNhTXRTbWZRYUk9In0= x-ctpclassification: CTP_IC x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] ethdev: fix statistics description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Nov 2016 08:28:42 -0000 Hi, John & Greg Would you please give any opinion for this patch ? I have looked through all PMDs and found not all statistics items can be su= pported by some NIC. For example, rx_nombuf, q_ipackets, q_opackets, q_ibytes and q_obytes a= re not supported by i40e. But when the function rte_eth_stats_get(uint8_t port_id, struct rte_eth_sta= ts *stats) is called for i40e PMD, Above un-supported statistics item in output stats are zero, this is not re= al value. So far, there is no way to know whether an item in struct rte_eth_stats is = supported or not only from this structure definition. Maybe some structure member can be added to indicate each of statistics ite= m valid or not. But this means ABI change. In following list, I list statistics support details of all PMDs. Hope it can be displayed in your screen. Thanks /Wei NIC ipackets opackets ibytes obytes imissed ierrors oerror= s rx_nombuf q_ipackets q_opacktes q_ibytes q_obytes q_errors af_packet y y y y n n y = n y y y y y bnx2x y y y y y y y = y n n n n n bnxt y y y y y y y = n y y y y y bonding y y y y y y y = y y y y y y cxgbe y y y y y y y = n y y y y y e1000(igb) y y y y y y y = n n n n n n e1000(igbvf) y y y y n n n = n n n n n n ena y y y y y y y = y n n n n n enic y y y y y y y = y n n n n n fm10k y y y y n n n = n y y y y n i40e y y y y y y y = n n n n n n i40evf y y y y n y y = n n n n n n ixgbe y y y y y y y = n y y y y y ixgbevf y y y y n n n = n n n n n n mlx4 y y y y n y y = y y y y y y mlx5 y y y y n y y = y y y y y y mpipe y y y y n y y = y y y y y y nfp y y y y y y y = y y y y y n null y y n n n n y = n y y n n y pcap y y y y n n y = n y y y y y qede y y y y y y y = y n n n n n ring y y n n n n y = n y y n n y szedata2 y y y y n n y = n y y y y y thunderx y y y y y y y = n y y y y n vhost y y y y n n y = n y y y y n virtio y y y y n y y = y y y y y n vmxnet3 y y y y n y y = y y y y y y xenvirt y y n n n n n = n n n n n n > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, October 4, 2016 5:35 PM > To: Dai, Wei ; Mcnamara, John > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ethdev: fix statistics description >=20 > 2016-08-26 18:08, Wei Dai: > > /** > > * A structure used to retrieve statistics for an Ethernet port. > > + * Not all statistics fields in struct rte_eth_stats are supported > > + * by any type of network interface card (NIC). If any statistics > > + * field is not supported, its value is 0 . > > */ > > struct rte_eth_stats { >=20 > I'm missing the point of this patch. > Why do you think it is a fix? >=20 > John, any opinion?