From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 2095610BFA for ; Wed, 21 Dec 2016 11:17:19 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP; 21 Dec 2016 02:17:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,382,1477983600"; d="scan'208";a="914744188" Received: from pgsmsx104.gar.corp.intel.com ([10.221.44.91]) by orsmga003.jf.intel.com with ESMTP; 21 Dec 2016 02:17:18 -0800 Received: from pgsmsx106.gar.corp.intel.com ([169.254.9.52]) by PGSMSX104.gar.corp.intel.com ([169.254.3.85]) with mapi id 14.03.0248.002; Wed, 21 Dec 2016 18:17:17 +0800 From: "Dai, Wei" To: "Yigit, Ferruh" , "Zhang, Helin" , "Ananyev, Konstantin" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 24/29] net/ixgbe/base: add EEE support for DNL-controlled PHYs Thread-Index: AQHSTfisFATSI8X3fUaJ0fAaNVy92KD5PPAAgBkJoBA= Date: Wed, 21 Dec 2016 10:17:17 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D63A30A51F@PGSMSX106.gar.corp.intel.com> References: <1480833100-48545-1-git-send-email-wei.dai@intel.com> <1480833100-48545-24-git-send-email-wei.dai@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTRiYzJhMDgtNDVjMC00YjQ1LTg5MTQtZmIxY2I4YjY1NGI5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImtRXC9mQUMwQUwzK1RtMWN6aVV1YmRcL3B6cWNVQnZoMUlOTXpNeVdcL2I4dEU9In0= x-ctpclassification: CTP_IC x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 24/29] net/ixgbe/base: add EEE support for DNL-controlled PHYs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Dec 2016 10:17:20 -0000 > -----Original Message----- > From: Yigit, Ferruh > Sent: Tuesday, December 6, 2016 3:41 AM > To: Dai, Wei ; Zhang, Helin ; > Ananyev, Konstantin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 24/29] net/ixgbe/base: add EEE support for > DNL-controlled PHYs >=20 > On 12/4/2016 6:31 AM, Wei Dai wrote: > > This patch adds EEE support for DNL-controlled PHYs. Because DNL >=20 > What is DNL? DNL is short for name of some method to control Marvel PHY. This git log message will be revised in v2 patch set. >=20 > > does not indicate EEE capability or status, this patch simply assumes > > that it is supported. As soon as there is a DNL-supported PHY that > > does not support EEE, there will be defects in this area because the > > driver will not report the EEE status correctly. > > This also deletes some now-unused definitions from an earlier Marvell > > PHY implementation and combines a device ID check into a switch > > statement. > > > > Signed-off-by: Wei Dai > > --- > > drivers/net/ixgbe/base/ixgbe_type.h | 8 -------- > > drivers/net/ixgbe/base/ixgbe_x550.c | 15 +++++++-------- > > 2 files changed, 7 insertions(+), 16 deletions(-) > > > > diff --git a/drivers/net/ixgbe/base/ixgbe_type.h > > b/drivers/net/ixgbe/base/ixgbe_type.h > > index 9ec17a9..f1761a3 100644 > > --- a/drivers/net/ixgbe/base/ixgbe_type.h > > +++ b/drivers/net/ixgbe/base/ixgbe_type.h > > @@ -3720,14 +3720,6 @@ enum ixgbe_fc_mode { > > ixgbe_fc_default > > }; > > > > -/* Master/slave control */ > > -enum ixgbe_ms_type { > > - ixgbe_ms_hw_default =3D 0, > > - ixgbe_ms_force_master, > > - ixgbe_ms_force_slave, > > - ixgbe_ms_auto > > -}; > > - >=20 > This seems not related to this patchset, also patch 15/29 has [1] again s= eems > unrelated to that patch, does it make sense to make these a separate patc= h? Yes, in v2 patch set, removing of above enum type will be in a separate one= .=20 >=20 > [1] > " > @@ -4046,8 +4112,8 @@ struct ixgbe_phy_info { > bool reset_disable; > ixgbe_autoneg_advertised autoneg_advertised; > ixgbe_link_speed speeds_supported; > - enum ixgbe_ms_type ms_type; > - enum ixgbe_ms_type original_ms_type; >=20 >=20