From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 717C3FA47; Thu, 9 Feb 2017 15:50:09 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP; 09 Feb 2017 06:50:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,349,1484035200"; d="scan'208";a="63099604" Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88]) by fmsmga005.fm.intel.com with ESMTP; 09 Feb 2017 06:50:07 -0800 Received: from pgsmsx106.gar.corp.intel.com ([169.254.9.9]) by KMSMSX153.gar.corp.intel.com ([172.21.73.88]) with mapi id 14.03.0248.002; Thu, 9 Feb 2017 22:50:05 +0800 From: "Dai, Wei" To: Olivier Matz , "dev@dpdk.org" , "Zhang, Helin" , "Ananyev, Konstantin" CC: Guo Fengtian , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset Thread-Index: AQHSbCz8L5tq8aowTkuBCuBqF2BFfaFbo9wAgAVGI7CAAATYQA== Date: Thu, 9 Feb 2017 14:50:05 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D63A3598F0@PGSMSX106.gar.corp.intel.com> References: <1484154254-31387-1-git-send-email-olivier.matz@6wind.com> <20170206145858.41447b6e@platinum> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmZlMmYwNzEtNWQ5ZC00MzNmLWJhYjctN2IwYTkzNmU3YjA0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjFiY1premN5Tmd4Y1VQK29cL3BLRlFkbkxVXC94NHQzd0Jrd0xZQUxmbEJSRT0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Feb 2017 14:50:10 -0000 Another way is to clear hw_stats->last_vfgprc/last_vfgorc/last_vfgptc/last_= vfmprc=20 at the same time PF is set down. > -----Original Message----- > From: Dai, Wei > Sent: Thursday, February 9, 2017 10:38 PM > To: 'Olivier Matz' ; dev@dpdk.org; Zhang, Helin > ; Ananyev, Konstantin > > Cc: Guo Fengtian ; stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF = reset >=20 > The stats register can rewind to zero when the port is running for a long= period. > So I am afraid that this check is not always correct. > Why not introduce a variable to directly indicate whether the resulted st= ats > should be updated or not. >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Olivier Matz > > Sent: Monday, February 6, 2017 9:59 PM > > To: dev@dpdk.org; Zhang, Helin ; Ananyev, > > Konstantin > > Cc: Guo Fengtian ; stable@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a > > PF reset > > > > Hi, > > > > On Wed, 11 Jan 2017 18:04:14 +0100, Olivier Matz > > > > wrote: > > > From: Guo Fengtian > > > > > > When PF is set down, in VF, the value of stats register is zero. > > > So only increase stats when it's non zero. > > > > > > Fixes: af75078fece3 ("first public release") > > > > > > CC: stable@dpdk.org > > > Signed-off-by: Guo Fengtian > > > Signed-off-by: Olivier Matz > > > > Ping > > > > > > Thanks, > > Olivier