From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id B4EB8532E; Thu, 13 Apr 2017 11:22:59 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Apr 2017 02:22:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,194,1488873600"; d="scan'208";a="845406460" Received: from pgsmsx106.gar.corp.intel.com ([10.221.44.98]) by FMSMGA003.fm.intel.com with ESMTP; 13 Apr 2017 02:22:55 -0700 Received: from pgsmsx109.gar.corp.intel.com (10.221.44.109) by PGSMSX106.gar.corp.intel.com (10.221.44.98) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 13 Apr 2017 17:22:54 +0800 Received: from pgsmsx101.gar.corp.intel.com ([169.254.1.174]) by PGSMSX109.gar.corp.intel.com ([169.254.14.145]) with mapi id 14.03.0319.002; Thu, 13 Apr 2017 17:22:54 +0800 From: "Dai, Wei" To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= CC: "thomas.monjalon@6wind.com" , "harish.patil@cavium.com" , "rasesh.mody@cavium.com" , "stephen.hurd@broadcom.com" , "ajit.khaparde@broadcom.com" , "Lu, Wenzhuo" , "Zhang, Helin" , "Ananyev, Konstantin" , "Wu, Jingjing" , "Chen, Jing D" , "adrien.mazarguil@6wind.com" , "Richardson, Bruce" , "yuanhan.liu@linux.intel.com" , "maxime.coquelin@redhat.com" , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v4 1/3] ethdev: fix adding invalid MAC addr Thread-Index: AQHStDAouiaQq/aH706tJdnJ9ZOiNKHCdeQAgACQCsA= Date: Thu, 13 Apr 2017 09:22:54 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D650A65045@PGSMSX101.gar.corp.intel.com> References: <1491987746-10155-1-git-send-email-wei.dai@intel.com> <6bc635ce8d902ca8b3c6d907a5622febea2f8157.1492071245.git.wei.dai@intel.com> <20170413084440.GA14075@autoinstall.dev.6wind.com> In-Reply-To: <20170413084440.GA14075@autoinstall.dev.6wind.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWQ3OGY5YWQtNjU4MS00Mzg1LWJmOWUtOWE3ZGJmZjhlNDkyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImtWVEpmZTVVSzZiWWZQWnNZNnRUQVNiRXViUlFlbDVvVjBZSEcrXC95cENJPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/3] ethdev: fix adding invalid MAC addr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Apr 2017 09:23:00 -0000 Thanks, Nelio Laranjeiro. What about other parts, dear maintainers ? > -----Original Message----- > From: N=E9lio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > Sent: Thursday, April 13, 2017 4:45 PM > To: Dai, Wei > Cc: thomas.monjalon@6wind.com; harish.patil@cavium.com; > rasesh.mody@cavium.com; stephen.hurd@broadcom.com; > ajit.khaparde@broadcom.com; Lu, Wenzhuo ; Zhang, > Helin ; Ananyev, Konstantin > ; Wu, Jingjing ; Che= n, > Jing D ; adrien.mazarguil@6wind.com; Richardson, > Bruce ; yuanhan.liu@linux.intel.com; > maxime.coquelin@redhat.com; dev@dpdk.org; stable@dpdk.org > Subject: Re: [PATCH v4 1/3] ethdev: fix adding invalid MAC addr >=20 > On Thu, Apr 13, 2017 at 04:21:04PM +0800, Wei Dai wrote: > > some customers find adding mac addr to VF sometimes can fail, but it > > is still stored in dev->data->mac_addrs[ ]. So this can lead to some > > errors that assumes the non-zero entry in > > dev->data->mac_addrs[ ] is valid. > > > > Fixes: af75078fece3 ("first public release") > > Cc: stable@dpdk.org > > > > Signed-off-by: Wei Dai > > --- > > drivers/net/bnx2x/bnx2x_ethdev.c | 7 +++++-- > > drivers/net/bnxt/bnxt_ethdev.c | 12 ++++++------ > > drivers/net/e1000/base/e1000_api.c | 2 +- > > drivers/net/e1000/em_ethdev.c | 6 +++--- > > drivers/net/e1000/igb_ethdev.c | 5 +++-- > > drivers/net/enic/enic.h | 2 +- > > drivers/net/enic/enic_ethdev.c | 4 ++-- > > drivers/net/enic/enic_main.c | 6 +++--- > > drivers/net/fm10k/fm10k_ethdev.c | 3 ++- > > drivers/net/i40e/i40e_ethdev.c | 11 ++++++----- > > drivers/net/i40e/i40e_ethdev_vf.c | 8 ++++---- > > drivers/net/ixgbe/ixgbe_ethdev.c | 27 ++++++++++++++++++--------- > > drivers/net/mlx4/mlx4.c | 18 +++++++++++------- > > drivers/net/mlx5/mlx5.h | 4 ++-- > > drivers/net/mlx5/mlx5_mac.c | 16 ++++++++++------ > > drivers/net/qede/qede_ethdev.c | 6 ++++-- > > drivers/net/ring/rte_eth_ring.c | 3 ++- > > drivers/net/virtio/virtio_ethdev.c | 13 +++++++------ > > lib/librte_ether/rte_ethdev.c | 15 +++++++++------ > > lib/librte_ether/rte_ethdev.h | 2 +- > > 20 files changed, 100 insertions(+), 70 deletions(-) > > >=20 >=20 > For mlx changes, >=20 > Acked-by: Nelio Laranjeiro >=20 > -- > N=E9lio Laranjeiro > 6WIND