From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 5BC0F374F; Tue, 2 May 2017 03:51:35 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP; 01 May 2017 18:51:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,402,1488873600"; d="scan'208";a="1125462900" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by orsmga001.jf.intel.com with ESMTP; 01 May 2017 18:51:31 -0700 Received: from pgsmsx106.gar.corp.intel.com ([169.254.9.228]) by PGSMSX101.gar.corp.intel.com ([169.254.1.174]) with mapi id 14.03.0319.002; Tue, 2 May 2017 09:51:31 +0800 From: "Dai, Wei" To: "Lu, Wenzhuo" , "thomas.monjalon@6wind.com" , "harish.patil@cavium.com" , "rasesh.mody@cavium.com" , "stephen.hurd@broadcom.com" , "ajit.khaparde@broadcom.com" , "Zhang, Helin" , "Ananyev, Konstantin" , "Wu, Jingjing" , "Chen, Jing D" , "adrien.mazarguil@6wind.com" , "nelio.laranjeiro@6wind.com" , "Richardson, Bruce" , "yuanhan.liu@linux.intel.com" , "maxime.coquelin@redhat.com" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v4 1/3] ethdev: fix adding invalid MAC addr Thread-Index: AQHStDAouiaQq/aH706tJdnJ9ZOiNKHO5rcAgA0NnuCAA+ILAIAAjeaQ Date: Tue, 2 May 2017 01:51:30 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D650A788A3@PGSMSX106.gar.corp.intel.com> References: <1491987746-10155-1-git-send-email-wei.dai@intel.com> <6bc635ce8d902ca8b3c6d907a5622febea2f8157.1492071245.git.wei.dai@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B59B6C1@shsmsx102.ccr.corp.intel.com> <49759EB36A64CF4892C1AFEC9231E8D650A7836A@PGSMSX106.gar.corp.intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B59E5D7@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B59E5D7@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzFkNTFhZWQtNjAyOC00NzNlLWJlMzMtNzg4NTM2NTkzMjUxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InNtcXRFWnZRN0NWdmUzcFwvNjRsUUFCUWhaMXppWjU5MXNRVitieG9sWDljPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/3] ethdev: fix adding invalid MAC addr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 May 2017 01:51:37 -0000 > > > > > > > > int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int > > > > wait_to_complete) diff --git a/drivers/net/e1000/base/e1000_api.c > > > > b/drivers/net/e1000/base/e1000_api.c > > > > index f7cf83b..dcb53f7 100644 > > > > --- a/drivers/net/e1000/base/e1000_api.c > > > > +++ b/drivers/net/e1000/base/e1000_api.c > > > > @@ -855,7 +855,7 @@ int e1000_rar_set(struct e1000_hw *hw, u8 > > > > *addr, > > > > u32 index) > > > > if (hw->mac.ops.rar_set) > > > > return hw->mac.ops.rar_set(hw, addr, index); > > > > > > > > - return E1000_SUCCESS; > > > > + return E1000_ERR_NO_SPACE; > > > > } > > > NACK here. Normally we try to avoid changing base code. And I don't > > > think the change is necessary. > > > > If this code is not changed, the code in ethdev may get wrong return > > value and assume the failed MAC addr is added. > > Anyway, we can ask the base code to be revised by the associated team. > ' hw->mac.ops.rar_set ' cannot be NULL. That's why I think this change is= not > necessary. OK, I will follow your advice in my v6 patch set. Thanks