From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 6717B282 for ; Tue, 16 May 2017 05:34:19 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 May 2017 20:34:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,347,1491289200"; d="scan'208";a="1130838992" Received: from pgsmsx108.gar.corp.intel.com ([10.221.44.103]) by orsmga001.jf.intel.com with ESMTP; 15 May 2017 20:34:17 -0700 Received: from pgsmsx106.gar.corp.intel.com ([169.254.9.228]) by PGSMSX108.gar.corp.intel.com ([169.254.8.249]) with mapi id 14.03.0319.002; Tue, 16 May 2017 11:34:16 +0800 From: "Dai, Wei" To: Thomas Monjalon , Srinivasan J CC: "dev@dpdk.org" , "Lu, Wenzhuo" , "Ananyev, Konstantin" Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+ Thread-Index: AQHSucOi6VClq/LmlEaQUMd0cyxYEKHOvGOAgATQqYCAAA5zAIAAPD6AgADzvACAEhp9gIAAkraAgA72IJA= Date: Tue, 16 May 2017 03:34:15 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D650A7D260@PGSMSX106.gar.corp.intel.com> References: <1492685271-7583-1-git-send-email-srinidpdk@gmail.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B59C4B1@shsmsx102.ccr.corp.intel.com> <3282640.JDCqqrB9e9@xps> In-Reply-To: <3282640.JDCqqrB9e9@xps> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTY3OGRiMTctYTA1ZC00NTNjLWFlMmQtZmRiMTU4NmMzZDI4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjFmck04bWpWTjZsZzgzV1huWkVpY0pKeXRPMVVcL2ZDV1p1azUzTEpkM0VZPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 May 2017 03:34:19 -0000 Hi, Srini There is a bit confusion. Your patch shows that your code is added into the= function eth_ixgbevf_pci_remove( ). But it is not. It is added into the fucntion ixgbe_dev_start( ), right ? So would you please rebase it to R 17.05 ? Which type of ixgbe device id did you tested ? There are many MAC types with different device id. The function ixgbe_pf_reset_hw(hw) is called before your adding code. ixgbe_pf_reset_hw() calls hw->mac.ops.reset_hw( ) which may points to follo= wing different function for different MAC type. Ixgbe_reset_hw_82598( ) calls hw->phy.ops.init(hw) if hw->phy.reset_disable= =3D=3D false . Ixgbe_reset_hw_82599( ) calls hw->phy.ops.init(hw) unconditionally. ixgbe_reset_hw_X540( ) doesn't' call pw->phy.ops.init(hw). For X540, hw->p= hy.ops.init points to ixgbe_init_phy_ops_generic() which only initialize so= me function pointers. Ixgbe_rest_hw_x550em() calls hw->phy.ops.init(hw) unconditionally. And for VF, ixgbe_reset_hw_vf( ) and ixgbevf_hv_reset_hw_vf( ) don't call = hw->phy.ops.init(hw) anywhere. Thanks & Best Regards -Wei > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Sunday, May 7, 2017 6:36 AM > To: Srinivasan J > Cc: dev@dpdk.org; Lu, Wenzhuo ; Ananyev, > Konstantin > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapp= ed > SFP/SFP+ >=20 > 06/05/2017 15:51, Srinivasan J: > > Hi, > > Do we need an explicit "Acked-by" keyword for this > > patch to be accepted and applied? >=20 > Yes, given it is not a trivial patch, an ack from the maintainer is requi= red. > Anyway, it has been submitted too late for 17.05 testing.