From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id D8862377E for ; Mon, 17 Jul 2017 16:02:29 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2017 07:02:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,374,1496127600"; d="scan'208";a="1152343222" Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88]) by orsmga001.jf.intel.com with ESMTP; 17 Jul 2017 07:02:21 -0700 Received: from pgsmsx106.gar.corp.intel.com ([169.254.9.158]) by KMSMSX153.gar.corp.intel.com ([169.254.5.66]) with mapi id 14.03.0319.002; Mon, 17 Jul 2017 22:02:18 +0800 From: "Dai, Wei" To: Thomas Monjalon CC: "dev@dpdk.org" , "Lu, Wenzhuo" , "Ananyev, Konstantin" , "Wu, Jingjing" , "Xing, Beilei" , "Mcnamara, John" Thread-Topic: [dpdk-dev] [PATCH v7 0/5] Support NIC reset and keep same port id Thread-Index: AQHS+/HWedMRvUtg8E6FBCslNQGQxaJWVJcAgAG9kwA= Date: Mon, 17 Jul 2017 14:02:17 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D650B6366F@PGSMSX106.gar.corp.intel.com> References: <1499681144-26031-1-git-send-email-wei.dai@intel.com> <1499961223-45281-1-git-send-email-wei.dai@intel.com> <8733823.mcBcVaCldc@xps> In-Reply-To: <8733823.mcBcVaCldc@xps> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 0/5] Support NIC reset and keep same port id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jul 2017 14:02:30 -0000 Hi, Thomas Thanks for your expert guidance. I'll rework out v8 patch set to follow your guide and rebase to master brac= h. > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday, July 17, 2017 3:26 AM > To: Dai, Wei > Cc: dev@dpdk.org; Lu, Wenzhuo ; Ananyev, > Konstantin ; Wu, Jingjing > ; Xing, Beilei ; Mcnamara, > John > Subject: Re: [dpdk-dev] [PATCH v7 0/5] Support NIC reset and keep same > port id >=20 > 13/07/2017 17:53, Wei Dai: > > chagnes: > > v7: > > add description of NIC reset in doc/poll_mode_drv.rst >=20 > Thanks for bringing more explanations. > The texts have to be reviewed by a native english speaker. >=20 > About the organization of the doc, it is good to explain the VF use case = in the > prog guide as you do. But you should not add it to the doxygen. > The doxygen must be concise enough and explains only the API: > - when it can be called > - what a driver is doing when calling reset > - what is the expected state of the device after reset