From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 5B36F7CEC for ; Wed, 26 Jul 2017 17:34:39 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP; 26 Jul 2017 08:34:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,416,1496127600"; d="scan'208";a="1199567013" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by fmsmga002.fm.intel.com with ESMTP; 26 Jul 2017 08:34:34 -0700 Received: from pgsmsx106.gar.corp.intel.com ([169.254.9.158]) by PGSMSX102.gar.corp.intel.com ([10.221.44.80]) with mapi id 14.03.0319.002; Wed, 26 Jul 2017 23:27:10 +0800 From: "Dai, Wei" To: "Lu, Wenzhuo" , "Ananyev, Konstantin" CC: "dev@dpdk.org" Thread-Topic: [PATCH v3] net/ixgbe: add support of 2.5G and 5G on X550 Thread-Index: AQHTBh2Om0oPeOH4tUGQoVwMZqP2wKJlrdCAgACNC4A= Date: Wed, 26 Jul 2017 15:27:09 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D650B68D08@PGSMSX106.gar.corp.intel.com> References: <1501061376-41938-1-git-send-email-wei.dai@intel.com> <1501080191-35958-1-git-send-email-wei.dai@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B67CCEB@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B67CCEB@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTBhN2I5NTktOWI3ZS00ODExLWI0MzktZTVjOGUyY2JmMDkxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Imo3eXkxZDE2N2pTUHdBY2ljVDhwXC9iVlJ3TUJmdkNKVXRYSWE2bzFlQmlzPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: add support of 2.5G and 5G on X550 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jul 2017 15:34:40 -0000 > -----Original Message----- > From: Lu, Wenzhuo > Sent: Wednesday, July 26, 2017 11:02 PM > To: Dai, Wei ; Ananyev, Konstantin > > Cc: dev@dpdk.org > Subject: RE: [PATCH v3] net/ixgbe: add support of 2.5G and 5G on X550 >=20 > Hi Wei, >=20 > > -----Original Message----- > > From: Dai, Wei > > Sent: Wednesday, July 26, 2017 10:43 AM > > To: Lu, Wenzhuo ; Ananyev, Konstantin > > > > Cc: dev@dpdk.org; Dai, Wei > > Subject: [PATCH v3] net/ixgbe: add support of 2.5G and 5G on X550 > > > > This patch adds support of 2.5G and 5G ethernet interface on X550. > > > > Signed-off-by: Wei Dai > > --- > > drivers/net/ixgbe/base/ixgbe_type.h | 5 +++++ > > drivers/net/ixgbe/ixgbe_ethdev.c | 24 ++++++++++++++++++++++++ > > 2 files changed, 29 insertions(+) > > > > diff --git a/drivers/net/ixgbe/base/ixgbe_type.h > > b/drivers/net/ixgbe/base/ixgbe_type.h > > index bda8558..3fd5425 100644 > > --- a/drivers/net/ixgbe/base/ixgbe_type.h > > +++ b/drivers/net/ixgbe/base/ixgbe_type.h > > @@ -3408,6 +3408,11 @@ typedef u32 ixgbe_link_speed; #define > > IXGBE_LINK_SPEED_82599_AUTONEG > > (IXGBE_LINK_SPEED_100_FULL | \ > > IXGBE_LINK_SPEED_1GB_FULL | \ > > IXGBE_LINK_SPEED_10GB_FULL) > > +#define IXGBE_LINK_SPEED_X550_AUTONEG > > (IXGBE_LINK_SPEED_100_FULL | \ > > + IXGBE_LINK_SPEED_1GB_FULL | \ > > + IXGBE_LINK_SPEED_2_5GB_FULL | \ > > + IXGBE_LINK_SPEED_5GB_FULL | \ > > + IXGBE_LINK_SPEED_10GB_FULL) > > > > /* Physical layer type */ > > typedef u64 ixgbe_physical_layer; > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > b/drivers/net/ixgbe/ixgbe_ethdev.c > > index 194058f..bafe7f4 100644 > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > @@ -2650,6 +2650,22 @@ ixgbe_dev_start(struct rte_eth_dev *dev) > > speed =3D (hw->mac.type !=3D ixgbe_mac_82598EB) ? > > IXGBE_LINK_SPEED_82599_AUTONEG : > > IXGBE_LINK_SPEED_82598_AUTONEG; > A little confused here. I saw you erased these 3 lines of code in the pre= vious > version. Suppose it's better to remove them, right? Sorry, I forgot to remove them. I will rework on v4 patch. Thanks >=20 > > + switch (hw->mac.type) { > > + case ixgbe_mac_82598EB: > > + speed =3D IXGBE_LINK_SPEED_82598_AUTONEG; > > + break; > > + case ixgbe_mac_82599EB: > > + case ixgbe_mac_X540: > > + speed =3D IXGBE_LINK_SPEED_82599_AUTONEG; > > + break; > > + case ixgbe_mac_X550: > > + case ixgbe_mac_X550EM_x: > > + case ixgbe_mac_X550EM_a: > > + speed =3D IXGBE_LINK_SPEED_X550_AUTONEG; > > + break; > > + default: > > + speed =3D IXGBE_LINK_SPEED_82599_AUTONEG; > > + } > > } else { > > if (*link_speeds & ETH_LINK_SPEED_10G) > > speed |=3D IXGBE_LINK_SPEED_10GB_FULL; @@ - > > 3972,6 +3988,14 @@ ixgbe_dev_link_update_share(struct rte_eth_dev > *dev, > > link.link_speed =3D ETH_SPEED_NUM_1G; > > break; > > > > + case IXGBE_LINK_SPEED_2_5GB_FULL: > > + link.link_speed =3D ETH_SPEED_NUM_2_5G; > > + break; > > + > > + case IXGBE_LINK_SPEED_5GB_FULL: > > + link.link_speed =3D ETH_SPEED_NUM_5G; > > + break; > > + > > case IXGBE_LINK_SPEED_10GB_FULL: > > link.link_speed =3D ETH_SPEED_NUM_10G; > > break; > > -- > > 2.7.5