From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 2C57A7D22 for ; Thu, 27 Jul 2017 01:57:36 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP; 26 Jul 2017 16:57:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,417,1496127600"; d="scan'208";a="129920801" Received: from pgsmsx104.gar.corp.intel.com ([10.221.44.91]) by orsmga005.jf.intel.com with ESMTP; 26 Jul 2017 16:57:35 -0700 Received: from pgsmsx106.gar.corp.intel.com ([169.254.9.158]) by PGSMSX104.gar.corp.intel.com ([10.221.44.91]) with mapi id 14.03.0319.002; Thu, 27 Jul 2017 07:57:34 +0800 From: "Dai, Wei" To: "Lu, Wenzhuo" , "Ananyev, Konstantin" CC: "dev@dpdk.org" Thread-Topic: [PATCH v4] net/ixgbe: add support of 2.5G and 5G on X550 Thread-Index: AQHTBiQa5K+93sbiFUyDDPLTGMjLaaJlzqIAgAD6uNA= Date: Wed, 26 Jul 2017 23:57:33 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D650B68F33@PGSMSX106.gar.corp.intel.com> References: <1501080191-35958-1-git-send-email-wei.dai@intel.com> <1501082978-58784-1-git-send-email-wei.dai@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B67CE31@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B67CE31@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGQ0YTc2MGYtOTg0OC00ZThiLWJlYjItMDBhNDVlY2E4MjBmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IitISW5QYjYzajMrQTcydHRYdjBnUFwvdXVndUhOb1hXVmRYR0l4cldERFBzPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] net/ixgbe: add support of 2.5G and 5G on X550 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jul 2017 23:57:37 -0000 > -----Original Message----- > From: Lu, Wenzhuo > Sent: Thursday, July 27, 2017 12:59 AM > To: Dai, Wei ; Ananyev, Konstantin > > Cc: dev@dpdk.org > Subject: RE: [PATCH v4] net/ixgbe: add support of 2.5G and 5G on X550 >=20 > Hi Wei, >=20 > > -----Original Message----- > > From: Dai, Wei > > Sent: Wednesday, July 26, 2017 11:30 AM > > To: Lu, Wenzhuo ; Ananyev, Konstantin > > > > Cc: dev@dpdk.org; Dai, Wei > > Subject: [PATCH v4] net/ixgbe: add support of 2.5G and 5G on X550 > > > > This patch adds support of 2.5G and 5G ethernet interface on X550. > > > > Signed-off-by: Wei Dai > > --- > > drivers/net/ixgbe/base/ixgbe_type.h | 5 +++++ > > drivers/net/ixgbe/ixgbe_ethdev.c | 27 > ++++++++++++++++++++++++--- > > 2 files changed, 29 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/ixgbe/base/ixgbe_type.h > > b/drivers/net/ixgbe/base/ixgbe_type.h > > index bda8558..3fd5425 100644 > > --- a/drivers/net/ixgbe/base/ixgbe_type.h > > +++ b/drivers/net/ixgbe/base/ixgbe_type.h > > @@ -3408,6 +3408,11 @@ typedef u32 ixgbe_link_speed; #define > > IXGBE_LINK_SPEED_82599_AUTONEG > > (IXGBE_LINK_SPEED_100_FULL | \ > > IXGBE_LINK_SPEED_1GB_FULL | \ > > IXGBE_LINK_SPEED_10GB_FULL) > > +#define IXGBE_LINK_SPEED_X550_AUTONEG > > (IXGBE_LINK_SPEED_100_FULL | \ > > + IXGBE_LINK_SPEED_1GB_FULL | \ > > + IXGBE_LINK_SPEED_2_5GB_FULL | \ > > + IXGBE_LINK_SPEED_5GB_FULL | \ > > + IXGBE_LINK_SPEED_10GB_FULL) > Just noticed you changed base code. As we discussed before, I don't mean > that. Actually, I suggest to put it in, for example, ixgbe_ethdev.h Yes, you are right. Your method is better. I will follow it in my v5 patch.