From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 404381B5ED for ; Fri, 3 Nov 2017 10:22:06 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP; 03 Nov 2017 02:22:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,338,1505804400"; d="scan'208";a="171016544" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by fmsmga005.fm.intel.com with ESMTP; 03 Nov 2017 02:22:04 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.207]) by PGSMSX103.gar.corp.intel.com ([169.254.2.203]) with mapi id 14.03.0319.002; Fri, 3 Nov 2017 17:22:03 +0800 From: "Dai, Wei" To: "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" Thread-Topic: [PATCH v3 0/2] Fix 2 bugs of i40e VF interrupt found in l3fwd-power Thread-Index: AQHTVIH5VS5onf8SC0GUl7lXvDPI16MCYRKA Date: Fri, 3 Nov 2017 09:22:02 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D651555423@PGSMSX111.gar.corp.intel.com> References: <1509693243-43101-1-git-send-email-wei.dai@intel.com> <1509698850-13301-1-git-send-email-wei.dai@intel.com> In-Reply-To: <1509698850-13301-1-git-send-email-wei.dai@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDY3YzIxNmQtNjA2OS00ZmNlLWFlMzktNGY2OWM3ZDU3NWI1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjJNamZwdjBQWTVhY2pJSUdadVlGS2pcL3IzVjlEYlwvRXZZdVBFWEo5MUl6VT0ifQ== x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 0/2] Fix 2 bugs of i40e VF interrupt found in l3fwd-power X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2017 09:22:07 -0000 > -----Original Message----- > From: Dai, Wei > Sent: Friday, November 3, 2017 4:47 PM > To: Wu, Jingjing ; Xing, Beilei > > Cc: dev@dpdk.org; Dai, Wei > Subject: [PATCH v3 0/2] Fix 2 bugs of i40e VF interrupt found in l3fwd-po= wer >=20 > These 2 bugs can be observed from example/l3fwd-power run with i40e VF > bound to VFIO-PCI. The test steps are as follows: > 1. Disable LSC interrupt by clearing port_conf.intr_conf.lsc=3D0, as i40e > VF doesn't support LSC interrupt to avoid rte_eth_dev_configure() > failure. > 2. Create a VF from i40e host PF. Let PF run with kernel driver and bind > its VF to VFIO-PCI > 3. Run l3fwd-power like: l3fwd-power -l 18-19 -- -p 0x1 --config=3D'(0,0,= 19)' >=20 > Then, the following error message appears like: > EAL: Error enabling MSI-X interrupts for fd 18 This error is from > rte_intr_enable( )/vfio_enable_msix( ) when enabling Rx queue interrupt. > Same as the patch 06938770186a ("net/ixgbe: fix VFIO interrupt mapping in > VF"), to change VFIO MSI-X interrupts mapping, previous mapping should be > cleared first to avoid above error. >=20 > After fixing above VFIO-PCI MSI-X interrupt mapping. There is still the > following 2nd bug: l3fwd-power still can not be waked up by incoming > packets. >=20 > Same as the patch ca9d6597184b ("net/ixgbe: fix Rx queue interrupt > mapping in VF"), the interrupt vector of Rx queues should be mapped to > vector 1 to fix above 2nd bug. >=20 > These patches have passed test with l3fwd-power using i40e VF bound to > VFIO-PCI. > They also passed the test with testpmd rxonly and txonly mode with igb_ui= o > and VFIO-PCI. >=20 > Signed-off-by: Wei Dai > Tested-by: Lei Yao >=20 > --- > v3: > keep rte_intr_enable( ) for safety and align the style with other PMD. Keep rte_intr_enable( ) in i40evf_dev_rx_queue_intr_enable( ) for safety And align the style with other PMD. > remove 2 unsed macros. >=20 > v2: > only remap VFIO interrupt in i40evf_dev_start( ) >=20 > Wei Dai (2): > net/i40e: fix VFIO interrupt mapping in VF > net/i40e: fix Rx queue interrupt mapping in VF >=20 > drivers/net/i40e/i40e_ethdev_vf.c | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) >=20 > -- > 2.7.4