From: "Dai, Wei" <wei.dai@intel.com>
To: "Zhang, Helin" <helin.zhang@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v9] net/i40e: determine number of queues per VF during run time
Date: Tue, 9 Jan 2018 09:09:41 +0000 [thread overview]
Message-ID: <49759EB36A64CF4892C1AFEC9231E8D66CF20117@PGSMSX112.gar.corp.intel.com> (raw)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E71ACE6DDE@SHSMSX103.ccr.corp.intel.com>
Thanks to Helin and Ferruh,
I will submit v10 patch following your guide.
> -----Original Message-----
> From: Zhang, Helin
> Sent: Monday, January 8, 2018 2:01 PM
> To: Dai, Wei <wei.dai@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>;
> Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v9] net/i40e: determine number of queues per VF during
> run time
>
>
>
> > -----Original Message-----
> > From: Dai, Wei
> > Sent: Tuesday, December 26, 2017 11:25 PM
> > To: Wu, Jingjing; Xing, Beilei; Zhang, Helin
> > Cc: dev@dpdk.org; Dai, Wei
> > Subject: [PATCH v9] net/i40e: determine number of queues per VF during
> > run time
> >
> > Without this patch, the number of queues per i40e VF is defined as 4
> > by
> > CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF=4 in
> config/common_base.
> > It is fixed value determined in building time and can't be changed
> > during run time.
> > With this patch, the number of queues per i40e VF can be determinated
> > during run time. For example, if the PCI address of an i40e PF is
> > aaaa:bb.cc, with the EAL parameter -w aaaa:bb.cc,queue-num-per-vf=8 ,
> > the number of queues per VF created from this PF is 8.
> > If there is no "queue-num-per-vf" setting in EAL parameters, it is 4
> > by default as before. And if the value after the "queue-num-per-vf"
> > is invalid, it is set as 4 forcibly. The valid values include 1, 2, 4, 8, 16 .
> >
> > Signed-off-by: Wei Dai <wei.dai@intel.com>
> > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > ---
> > v9:
> > v9 = v8+v7, is a complete version for maintainer's convenience.
> > v8:
> > As v7 patch has been accepted into dpdk-next-net-intel, this patch
> > is based on v7 patch.
> > add description in i40e document
> > fix the last member of valid_keys[] for rte_kvargs_parse( )
> > add RTE_PMD_REGISTER_PARAM_STRING for this feature
> > v7:
> > use the macro instead of natural number
> > correct git log message as the EAL parameter is only valid for PF
> > v6:
> > fix a small bug when detecting end character of strtoul
> > v5:
> > fix git log message and WARNING of coding stype
> > v4:
> > use rte_kvargs instead of pervious parsing function;
> > use malloc/free instead of rte_zmalloc/rte_free.
> > v3:
> > fix WARNING of coding style issues from checkpatch@dpdk.org
> > v2:
> > fix WARNING of coding style issues from checkpatch@dpdk.org
> > ---
> > config/common_base | 1 -
> > doc/guides/nics/i40e.rst | 12 ++++---
> > drivers/net/i40e/i40e_ethdev.c | 75
> > +++++++++++++++++++++++++++++++++++++++---
> > 3 files changed, 78 insertions(+), 10 deletions(-)
>
> BTW, I think release notes should be updated for your modifications.
next prev parent reply other threads:[~2018-01-09 9:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-19 7:43 [dpdk-dev] [PATCH v2] " Wei Dai
2017-11-19 14:08 ` [dpdk-dev] [PATCH v3] " Wei Dai
2017-11-20 11:32 ` Ananyev, Konstantin
2017-11-22 2:46 ` Dai, Wei
2017-11-22 14:10 ` [dpdk-dev] [PATCH v4] " Wei Dai
2017-11-24 6:12 ` [dpdk-dev] [PATCH v5] " Wei Dai
2017-11-27 8:08 ` [dpdk-dev] [PATCH v6] " Wei Dai
2017-12-03 11:19 ` Ananyev, Konstantin
2017-12-08 1:53 ` [dpdk-dev] [PATCH v7] " Wei Dai
2017-12-11 2:33 ` Peng, Yuan
2017-12-20 5:59 ` Zhang, Helin
2017-12-25 11:45 ` [dpdk-dev] [PATCH v8] " Wei Dai
2017-12-26 15:24 ` [dpdk-dev] [PATCH v9] " Wei Dai
2018-01-08 6:00 ` Zhang, Helin
2018-01-09 9:09 ` Dai, Wei [this message]
2018-01-08 13:23 ` Ferruh Yigit
2018-01-09 8:56 ` [dpdk-dev] [PATCH v10] " Wei Dai
2018-01-09 14:36 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49759EB36A64CF4892C1AFEC9231E8D66CF20117@PGSMSX112.gar.corp.intel.com \
--to=wei.dai@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).