Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add commands to test new Rx offload API

["Dai, Wei" <wei.dai@intel.com>]

> -----Original Message-----
> From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
> Sent: Monday, March 12, 2018 4:43 PM
> To: Dai, Wei <wei.dai@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add commands to test
> new Rx offload API
> 
> On 03/12/2018 11:15 AM, Wei Dai wrote:
> > Add following testpmd run-time commands to support test of new Rx
> > offload API:
> > rx_offload get capability <port_id>
> > rx_offload get configuration <port_id> rx_offload enable|disable
> > per_port vlan_strip|ipv4_cksum... <port_id> rx_offload enable|disable
> > per_queue vlan_strip|iipv4_cksum... <port_id> <queue_id>
> >
> > Above last 2 commands should be run when the port is stopped.
> >
> > Signed-off-by: Wei Dai <wei.dai@intel.com>
> > ---
> >   app/test-pmd/cmdline.c | 456
> +++++++++++++++++++++++++++++++++++++++++++++++++
> >   app/test-pmd/testpmd.c |  15 +-
> >   app/test-pmd/testpmd.h |   1 +
> >   3 files changed, 470 insertions(+), 2 deletions(-)
> >
> > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> > d1dc1de..1a08b3d 100644
> > --- a/app/test-pmd/cmdline.c
> > +++ b/app/test-pmd/cmdline.c
> > @@ -15996,6 +15996,458 @@ cmdline_parse_inst_t
> cmd_ptype_mapping_update = {
> >   	},
> >   };
> >
> > +static const char * const rx_offload_names[] = {
> > +	"VLAN_STRIP",
> > +	"IPV4_CKSUM",
> > +	"UDP_CKSUM",
> > +	"TCP_CKSUM",
> > +	"TCP_LRO",
> > +	"QINQ_STRIP",
> > +	"OUTER_IPV4_CKSUM",
> > +	"MACSEC_STRIP",
> > +	"HEADER_SPLIT",
> > +	"VLAN_FILTER",
> > +	"VLAN_EXTEND",
> > +	"JUMBO_FRAME",
> > +	"CRC_STRIP",
> > +	"SCATTER",
> > +	"TIMESTAMP",
> > +	"SECURITY"
> > +};
> 
> There are already rte_rx_offload_names in librte_ethdev/rte_ethdev.c and
> rte_eth_dev_rx_offload_name() function in API.
Andrew, thanks for your feedback.
I will use rte_eth_dev_rx_offload_name( ) in my v2 patch set.