From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7551BA04B5; Wed, 13 Jan 2021 14:04:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09395140D1E; Wed, 13 Jan 2021 14:04:43 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id DDA71140D1B for ; Wed, 13 Jan 2021 14:04:41 +0100 (CET) IronPort-SDR: SuXwWRcjR3UsuzfNDLmc4Jfkm1+HfBwCZvCszOROLiu3yl0x+qSR4W+KP/Y2tGv/FuQmQjFej6 MRKA5kMJYxSA== X-IronPort-AV: E=McAfee;i="6000,8403,9862"; a="157380297" X-IronPort-AV: E=Sophos;i="5.79,344,1602572400"; d="scan'208";a="157380297" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 05:04:39 -0800 IronPort-SDR: /FUeNHbvK6rPzl1WhaHjhc+x2T7L27bw1JaBm/FkWScvy+SmPv3twQTua4EQOtxjeEJVpshjHc yFWXP8BxeAPw== X-IronPort-AV: E=Sophos;i="5.79,344,1602572400"; d="scan'208";a="381843003" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.253.108]) ([10.213.253.108]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 05:04:36 -0800 To: Lance Richardson Cc: dev@dpdk.org, Liang Ma , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Ray Kinsella , Neil Horman , "Ananyev, Konstantin" , gage.eads@intel.com, timothy.mcdaniel@intel.com, david.hunt@intel.com, Bruce Richardson , chris.macnamara@intel.com References: <1604315406-27669-1-git-send-email-liang.j.ma@intel.com> <8f06ba8347a3b464eba41ee4985b83934422c89a.1608213657.git.anatoly.burakov@intel.com> From: "Burakov, Anatoly" Message-ID: <497633b8-2887-66ab-032c-6b6b04896da8@intel.com> Date: Wed, 13 Jan 2021 13:04:34 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v12 06/11] ethdev: add simple power management API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12-Jan-21 8:32 PM, Lance Richardson wrote: > On Thu, Dec 17, 2020 at 9:08 AM Anatoly Burakov > wrote: >> >> From: Liang Ma >> >> Add a simple API to allow getting the monitor conditions for >> power-optimized monitoring of the RX queues from the PMD, as well as >> release notes information. >> >> Signed-off-by: Liang Ma >> Signed-off-by: Anatoly Burakov >> Acked-by: Konstantin Ananyev >> --- > >> /** >> * @internal A structure containing the functions exported by an Ethernet driver. >> */ >> @@ -917,6 +937,8 @@ struct eth_dev_ops { >> /**< Set up the connection between the pair of hairpin queues. */ >> eth_hairpin_queue_peer_unbind_t hairpin_queue_peer_unbind; >> /**< Disconnect the hairpin queues of a pair from each other. */ >> + eth_get_monitor_addr_t get_monitor_addr; >> + /**< Get next RX queue ring entry address. */ >> }; >> > > The implementation of get_monitor_addr will have much in common with > the rx_descriptor_status API in struct rte_eth_dev, including the property > that it will likely not make sense for it to be called concurrently with > rx_pkt_burst on a given queue. Might it make more sense to have this > API in struct rte_eth_dev instead of struct eth_dev_ops? > I don't have an opinion on this as this code isn't really my area of expertise. I'm fine with wherever the community thinks this code should be. Any other opinions? -- Thanks, Anatoly