Re: [dpdk-dev] [EXT] [PATCH v6 03/14] doc: remove references to make from NICs guides

[Thomas Monjalon <thomas@monjalon.net>]

09/10/2020 14:00, Igor Russkikh:
> > --- a/doc/guides/nics/qede.rst
> > +++ b/doc/guides/nics/qede.rst
> > @@ -106,22 +106,9 @@ Performance note
> >  Config File Options
> >  ~~~~~~~~~~~~~~~~~~~
> > 
> > -The following options can be modified in the ``.config`` file. Please note 
> > that
> > -enabling debugging options may affect system performance.
> > +The following option can be modified in the ``config/rte_config.h`` file.
> > 
> > -- ``CONFIG_RTE_LIBRTE_QEDE_PMD`` (default **y**)
> > -
> > -  Toggle compilation of QEDE PMD driver.
> 
> This one is correctly removed, but the below defines,
> 
> > -- ``CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX`` (default **n**)
> > -
> > -  Toggle display of transmit fast path run-time messages.
> > -
> > -- ``CONFIG_RTE_LIBRTE_QEDE_DEBUG_RX`` (default **n**)
> > -
> > -  Toggle display of receive fast path run-time messages.
> > -
> > -- ``CONFIG_RTE_LIBRTE_QEDE_FW`` (default **""**)
> > +- ``RTE_LIBRTE_QEDE_FW`` (default **""**)
> > 
> >    Gives absolute path of firmware file.
> >    ``Eg: "/lib/firmware/qed/qed_init_values-8.40.33.0.bin"``
> 
> These all still exist. I believe "CONFIG_" prefix should be removed here, but
> the defines and code behind them should stay.

I believe the same comment applies to multiple drivers which have
compilation options and probably should keep this information.

That's the main reason why I didn't apply these patches so far,
waiting for feedbacks.
It has been decided in a maintainers meeting to apply the patches anyway,
but given we have a request for qede, I think it blocks applying this v6.