From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BAA78A04B6; Sun, 11 Oct 2020 23:01:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1E1A91B755; Sun, 11 Oct 2020 23:01:53 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id 0112D1B650 for ; Sun, 11 Oct 2020 23:01:51 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 4504E580246; Sun, 11 Oct 2020 17:01:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 11 Oct 2020 17:01:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= H58ta8TQMDU4ggp93dfmVppqTcmz1v4glPHsSjF0Dxc=; b=dzZXzAn6HQh12FOU tHAY8GVHQy8CuyTxvskyAVXpn4m/d6lyz0f0lVwqdMuFhwIT4xnQ0kXNO01vvAgK DeCYvGN44mHfzwZw1dPWOE7KYMmPYyC/dYSfZNGgxkL3u+Yk8sihvTX6r3SfCzQi 7tMMN4Dx8T1fzAlwWhlD4M0SX9Cl/X1iWe8r+BvU2KdihXkBETxUmVTZkOpZ4NMz ZeSJDacXxoDggS+G96vfwOvN4tq1/SrASNZs1jbFdtSJuZYvzWaMMEWqwR1P8dyv cFjcVKKzw5mzAyVvA5draZKSSBdYXuTgJ14TPYklL7w6WT8jQjWkpP7qanecXo0j esycig== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=H58ta8TQMDU4ggp93dfmVppqTcmz1v4glPHsSjF0D xc=; b=SSdTBFXL/z8RsJJhM6xoNK4y3lb47wdrN+U40vEHDFfMxNjocNRrrEnOs MJPjAmRqVeRImN/lGFaJPzkHmfVTHcGwaEzCZhP1pfDaumsb8OSIRuExKhZN7Zna n6ms4zBttTli4x75J4fxx9EMUHoG5j3xRiR43N2mFKbfb6A8ORbzUkhvCw5rsIg4 UnKhoVggh9BztCNdOD61PB8OszQgUoNSCAzEh6lCoH26km1n2DLuqs249XzpjEMv 7xnESrX15uTqW1MaeN6w0a6xq2gCrVkCHdfgkp/j8tX4WMKBdVH4D81lKXtNrZrU HTO11mzzSGHeComFnhp6JFo1Dwawg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrheehgdduheekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9B9303280060; Sun, 11 Oct 2020 17:01:43 -0400 (EDT) From: Thomas Monjalon To: Ciara Power Cc: dev@dpdk.org, Bruce Richardson , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Somalapuram Amaranath , Rasesh Mody , Somnath Kotur , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , John Daley , Hyong Youb Kim , Gaetan Rivet , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Wei Hu (Xavier)" , "Min Hu (Connor)" , Yisen Zhuang , Beilei Xing , Jeff Guo , Qiming Yang , Haiyue Wang , Alfredo Cardigliano , Rosen Xu , Ferruh Yigit , Shijith Thotton , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Martin Spinler , Heinrich Kuhn , Harman Kalra , Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda , Andrew Rybchenko , Jasvinder Singh , Cristian Dumitrescu , Maxime Coquelin , Chenbo Xia , Zhihong Wang , Igor Russkikh Date: Sun, 11 Oct 2020 23:01:42 +0200 Message-ID: <4977739.bl39PjtFQs@thomas> In-Reply-To: References: <20200807123009.21266-1-ciara.power@intel.com> <20201009102140.20730-4-ciara.power@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [EXT] [PATCH v6 03/14] doc: remove references to make from NICs guides X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/10/2020 14:00, Igor Russkikh: > > --- a/doc/guides/nics/qede.rst > > +++ b/doc/guides/nics/qede.rst > > @@ -106,22 +106,9 @@ Performance note > > Config File Options > > ~~~~~~~~~~~~~~~~~~~ > > > > -The following options can be modified in the ``.config`` file. Please note > > that > > -enabling debugging options may affect system performance. > > +The following option can be modified in the ``config/rte_config.h`` file. > > > > -- ``CONFIG_RTE_LIBRTE_QEDE_PMD`` (default **y**) > > - > > - Toggle compilation of QEDE PMD driver. > > This one is correctly removed, but the below defines, > > > -- ``CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX`` (default **n**) > > - > > - Toggle display of transmit fast path run-time messages. > > - > > -- ``CONFIG_RTE_LIBRTE_QEDE_DEBUG_RX`` (default **n**) > > - > > - Toggle display of receive fast path run-time messages. > > - > > -- ``CONFIG_RTE_LIBRTE_QEDE_FW`` (default **""**) > > +- ``RTE_LIBRTE_QEDE_FW`` (default **""**) > > > > Gives absolute path of firmware file. > > ``Eg: "/lib/firmware/qed/qed_init_values-8.40.33.0.bin"`` > > These all still exist. I believe "CONFIG_" prefix should be removed here, but > the defines and code behind them should stay. I believe the same comment applies to multiple drivers which have compilation options and probably should keep this information. That's the main reason why I didn't apply these patches so far, waiting for feedbacks. It has been decided in a maintainers meeting to apply the patches anyway, but given we have a request for qede, I think it blocks applying this v6.