From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8D4042D8D; Thu, 29 Jun 2023 17:31:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6EB740EDB; Thu, 29 Jun 2023 17:31:16 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 32C5C406B7 for ; Thu, 29 Jun 2023 17:31:15 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id B55A95C008C; Thu, 29 Jun 2023 11:31:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 29 Jun 2023 11:31:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1688052673; x=1688139073; bh=3jEI3aKblLb+8Nnybr+sYtrA/YijVznMo2o X/oqAlJo=; b=ck5MRszEajb0eKiFHu3u8dLTqxmB/1ynYLSorgA+HReNCCZ7mgu RmIDJ1d7AK7b6ONutMG+gLwKAn9j0XpimJUkbmDG5tdbifX/JbbGWgnhBl1CV9Da OZeqX6p4g5GAcR2Vd6wwPYIUbyHJboaNcMomHMedn2MoSw56Ixh/vlSiCSmcAG5p J9T7YJMxcLJx4YKh+JVIh18NmCGrBB41gN2wqS+BhTB7xiKe0M3iZ/4MsQGElhRa ZMmAnu1E5WUltt7jOn6eTFCIyyWo9CnrFZiGHIVLRGCl8DIDf0daU2YA5ZVgG8Nt Mg9KAS1UAhs07+mjbF7S1TeK9+Nj6POxDSA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1688052673; x=1688139073; bh=3jEI3aKblLb+8Nnybr+sYtrA/YijVznMo2o X/oqAlJo=; b=W3iurt53/ulvs24VK30Zp0R4VXFUK6YKamOFU+DBykM67LwIeeU dWulMVYyHDYpRfIE5pzMgNrXPdIuiE5eMGrfSJ91SJIW1yCVAEpu7O3DZR2vyysT 9y1wzt7zvDbYhhL0uPpl4UyN3AfTxrFM76LGcomSCCSY1glUKEiNl2dlanFW7QkP DKL2QOZXsZkMYnU/HTa50iRPv2Liz4NwWVwT9I3pG15q/cmyUu2mWs8pruRV44nk 4OOaNqj1n8gXqbjynvPxFiMMZCcKvKd3f96KxtcqTmG7avBdT1KMB97aFmHY2ziL V0b4+EGLVdM5t48x/G3Q/OJ5mnE9yG4Lz5g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrtdeggdeltdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Jun 2023 11:31:11 -0400 (EDT) From: Thomas Monjalon To: David Marchand , Ferruh Yigit , Kiran Kumar K Cc: dev@dpdk.org, Ori Kam , Andrew Rybchenko Subject: Re: [PATCH] ethdev: fix Tx queue mask endianness Date: Thu, 29 Jun 2023 17:31:09 +0200 Message-ID: <4981207.a9HWlOh95j@thomas> In-Reply-To: <20230629135839.974700-1-david.marchand@redhat.com> References: <20230629135839.974700-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 29/06/2023 15:58, David Marchand: > Even if harmless, this endianness tag is incorrect as the tx_queue field > is declared as a host integer. > Additionally, this breaks OVS compilation with sparse. > > Fixes: 41f6bdc7615a ("ethdev: add Tx queue flow matching item") > > Signed-off-by: David Marchand > --- > lib/ethdev/rte_flow.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index 3fe57140f9..86ed98c562 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -2307,7 +2307,7 @@ struct rte_flow_item_tx_queue { > /** Default mask for RTE_FLOW_ITEM_TX_QUEUE. */ > #ifndef __cplusplus > static const struct rte_flow_item_tx_queue rte_flow_item_tx_queue_mask = { > - .tx_queue = RTE_BE16(0xffff), > + .tx_queue = 0xffff, As I said in an earlier comment about the same issue, UINT16_MAX would be better.