From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id B0C88E72 for ; Wed, 11 Nov 2015 11:09:22 +0100 (CET) Received: by wmvv187 with SMTP id v187so48485377wmv.1 for ; Wed, 11 Nov 2015 02:09:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=0P8XnI06lijj6wgxIK82towqG1Ap8AOxfiHoocBYlpk=; b=tu+UIE1mGYMf9o3N5J+rdzeEv5CXexAe9L6ll0ppMNnEGpMF8DVZ0tDTHaiuK/RBvE UJVFYBwY2RXlA42+rg0dB+ZIK2pg8Jia01NX65FlbmB1ILcbd3xW/bEpQ7LeFWC0uceg TSRZNquVNXFxOpOZjAxvj8PznKAeHBJ2TGSDnzyDQNt8onttPlDyBsz9N1nJbUBjKuKg rJVHajXOXwGY2Udu9LjvsBssSEyYHY7sqYZhgKcxhI7o2i14iqK3FXcAW9GYOXgnh089 xPD2a4/WK2pMn6a6jormcJOPbiNmn3C9tfM7m3K7NcjJUrGA215Mh/ohGzGAspaQ/O+2 w7Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=0P8XnI06lijj6wgxIK82towqG1Ap8AOxfiHoocBYlpk=; b=GEaU0Se5USUaChHjVuqa95nBNdCsLBk/H78CylPCXJ/YMGubvk5Dp3EkiijDnv1tOg 1eDzf0JlmdhoKtcdcQUUj4sXPspKahVRTNrb1+CBqG8KlaQXizm4OHwU7nVzordW4mge GW9zQmUJLqK+snGIaqe7ZMaxKxELiYWyLQp7xfkNuMO8gu5nfIu5q8uV1GnkQ+AXRJ4p GYOcShJC9v7j/BzpPr9pRMI0t+VoLfP8psFrNzImLJ+9sV2eVWs34qthqpqZVVVKBaX4 hY5u7RMzTBIxMx2SiauPbuuVdK/V4INlwGXuFJ0oDYtGqm6J96OK/KPy84XvT25aBZ33 t8VQ== X-Gm-Message-State: ALoCoQleoSzInPPYfFmCPb/fDcgleJQxHj09bGBooWq7yyhh58ZHnbuZyFBfAP6nR1ulaYHEVukI X-Received: by 10.28.14.140 with SMTP id 134mr9537416wmo.44.1447236562579; Wed, 11 Nov 2015 02:09:22 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id u185sm2193735wmu.19.2015.11.11.02.09.21 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Nov 2015 02:09:22 -0800 (PST) From: Thomas Monjalon To: "Liu, Jijiang" , Yuanhan Liu Date: Wed, 11 Nov 2015 11:08:10 +0100 Message-ID: <4986896.Ej2aoXBN66@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC22BDA74A@SHSMSX101.ccr.corp.intel.com> References: <1447224046-1169-1-git-send-email-jijiang.liu@intel.com> <20151111084419.GC2326@yliu-dev.sh.intel.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC22BDA74A@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, "Michael S. Tsirkin" Subject: Re: [dpdk-dev] [PATCH v4 7/8] virtio/lib:add virtio guest offload capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Nov 2015 10:09:22 -0000 2015-11-11 08:53, Liu, Jijiang: > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > > On Wed, Nov 11, 2015 at 08:38:29AM +0000, Liu, Jijiang wrote: > > > According to virtio standard, those fileds should be set. > > > > If so, you'd better quote them here, or even to your patch commit. > > In the Virtual I/O Device (VIRTIO) Version 1.0 Committee Specification 02, > > (1) VIRTIO_NET_F_GUEST_CSUM (1) Driver handles packets with partial checksum. > > (2) If the VIRTIO_NET_F_GUEST_CSUM feature was negotiated, the VIRTIO_NET_HDR_F_NEEDS_- > CSUM bit in flags MAY be set: if so, the checksum on the packet is incomplete and csum_start > and csum_offset indicate how to calculate it (see Packet Transmission point 1). > > (3) If the VIRTIO_NET_F_GUEST_TSO4, TSO6 or UFO options were negotiated, then gso_type > MAY be something other than VIRTIO_NET_HDR_GSO_NONE, and gso_size field indicates > the desired MSS (see Packet Transmission point 2). > > The information can be included in the next version of patch set. Yes quoting specifications or datasheets in commit messages is a really good idea. Thanks for improving the quality of the git history.