From: Thomas Monjalon <thomas@monjalon.net>
To: Rami Rosen <ramirose@gmail.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/1] remove unnecessray fw declarations
Date: Sun, 18 Nov 2018 23:45:58 +0100 [thread overview]
Message-ID: <4993609.zzt5v1ZH8Z@xps> (raw)
In-Reply-To: <20180822143731.3971-1-ramirose@gmail.com>
22/08/2018 16:37, Rami Rosen:
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -435,9 +435,6 @@ static int eth_event_callback(portid_t port_id,
> static void eth_dev_event_callback(char *device_name,
> enum rte_dev_event_type type,
> void *param);
> -static int eth_dev_event_callback_register(void);
> -static int eth_dev_event_callback_unregister(void);
I has been fixed by 2049c5113fe8 ("app/testpmd: use hotplug failure handler").
However I agree that some forward declarations could be removed,
ideally all.
Generally speaking, a lot of cleanup could be done in this file.
prev parent reply other threads:[~2018-11-18 22:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 14:37 Rami Rosen
2018-11-18 22:45 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4993609.zzt5v1ZH8Z@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ramirose@gmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).