* [dpdk-dev] [PATCH 1/1] remove unnecessray fw declarations
@ 2018-08-22 14:37 Rami Rosen
2018-11-18 22:45 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Rami Rosen @ 2018-08-22 14:37 UTC (permalink / raw)
To: dev; +Cc: stable, Rami Rosen
Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
app/test-pmd/testpmd.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index ee48db2a3..8a31722db 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -435,9 +435,6 @@ static int eth_event_callback(portid_t port_id,
static void eth_dev_event_callback(char *device_name,
enum rte_dev_event_type type,
void *param);
-static int eth_dev_event_callback_register(void);
-static int eth_dev_event_callback_unregister(void);
-
/*
* Check if all the ports are started.
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH 1/1] remove unnecessray fw declarations
2018-08-22 14:37 [dpdk-dev] [PATCH 1/1] remove unnecessray fw declarations Rami Rosen
@ 2018-11-18 22:45 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2018-11-18 22:45 UTC (permalink / raw)
To: Rami Rosen; +Cc: dev, stable
22/08/2018 16:37, Rami Rosen:
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -435,9 +435,6 @@ static int eth_event_callback(portid_t port_id,
> static void eth_dev_event_callback(char *device_name,
> enum rte_dev_event_type type,
> void *param);
> -static int eth_dev_event_callback_register(void);
> -static int eth_dev_event_callback_unregister(void);
I has been fixed by 2049c5113fe8 ("app/testpmd: use hotplug failure handler").
However I agree that some forward declarations could be removed,
ideally all.
Generally speaking, a lot of cleanup could be done in this file.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-18 22:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-22 14:37 [dpdk-dev] [PATCH 1/1] remove unnecessray fw declarations Rami Rosen
2018-11-18 22:45 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).