From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 4772AAAD1 for ; Wed, 21 Mar 2018 22:05:55 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B6DFE20E83; Wed, 21 Mar 2018 17:05:54 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 21 Mar 2018 17:05:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=ASuXrKwZqK8zA8e3eGYazUrKab A1MMpkKQRKhkIP8cs=; b=q6nIAb0GMK5aiSYIVarEabeOoNZywnJwkSAKCjabUw oL30TTXsGl8Wda5se5eXCbK+Krsu8PbzxqhUgrYcnTSzuVPUuguuv2IeebS09NST LLczNNb4W5EXn1GaToiml1XYP5BQu15IQjaTcaoNMLrJAwZCB4JzcTC8BRNnt3Ox Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=ASuXrK wZqK8zA8e3eGYazUrKabA1MMpkKQRKhkIP8cs=; b=nPLZFP174WSboVBOItD8ct ty6jt6EXN8GO6YuF8jpkhfTksFtnq00/aDvxKCyGB8iZAVV3KssEqtT02qfvJz5X LS+WfizghmVGvV64+kUdnMNuHNqndWAz5AXrekbGnKg7mB5Ev7JghbciMAIWFrs0 ZbIDg0gCSXZW7VgEYEqRnUJtr+fBELtWUJWztjSCVzOQQNQBw5nGAzTJfvaE4/jf sedSx99xaN49rbgNvHSWtKxyJpJnt7/l9hUZRYYIzcaIeRajx2YsEQX2zHCYa8Xh gFYHDjIb1BZ8bsUXOJ9DigLFlMOtkiaLEmmNyaxTKnM4ZuI4sDvQqbOfItEgdxCg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0C6C224232; Wed, 21 Mar 2018 17:05:53 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: Neil Horman , John McNamara , Marko Kovacevic , dev@dpdk.org Date: Wed, 21 Mar 2018 22:05:53 +0100 Message-ID: <4994557.sDfdp0IYcD@xps> In-Reply-To: <20180321194730.52068-2-ferruh.yigit@intel.com> References: <20180320112631.107105-1-ferruh.yigit@intel.com> <20180321194730.52068-1-ferruh.yigit@intel.com> <20180321194730.52068-2-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 2/2] ethdev: add new offload flag to keep CRC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 21:05:55 -0000 21/03/2018 20:47, Ferruh Yigit: > DEV_RX_OFFLOAD_KEEP_CRC offload flag added. > > DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release but default > behavior in PMDs is to strip the CRC independent from this flag. > > Until DEV_RX_OFFLOAD_CRC_STRIP flag is removed: > - Setting both KEEP_CRC & CRC_STRIP is INVALID > - Setting only CRC_STRIP PMD should strip the CRC > - Setting only KEEP_CRC PMD should keep the CRC > - Not setting both PMD should strip the CRC It is the same as saying that DEV_RX_OFFLOAD_CRC_STRIP has no effect :)