From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1AD3CA0524; Mon, 12 Apr 2021 23:16:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F88E141296; Mon, 12 Apr 2021 23:16:43 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 89438141258 for ; Mon, 12 Apr 2021 23:16:42 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 2E44F5C0180; Mon, 12 Apr 2021 17:16:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 12 Apr 2021 17:16:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= j1qXsi0muJxrk4YiVJ01aAX+MkLkiCRow//95dt9r3M=; b=2sof/tiClw69QKu1 srRvM8I29te5aRSRP2ORfuADltl+f58GNBVZ26FfcnhOakw6dVIg/RwdKQx+oYIg RAsCsXCw47K3Ylua8BwbVlNtbaZrTOoSal04IdwCbiSXOfWT/ez/CS0J1tFGcAP5 2qTzHleE81aDSeom4t9EO+Ez4Jj/gx5UFZbEVRzOdEuehTvlGQMRQ6EZBhCAoLyP wvJLFhZO/np4jqVucDRsfoU59IeMEpZdJOBRfFlk8UtlQFQBR1uAa7rek3mPgQBK 6j4Sn2yJ8Nev5n79XZZCYKGq/YxwxFt1sgdXnRC2oDKhLn3Ren3BJzt2qP9KExqS SSVI0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=j1qXsi0muJxrk4YiVJ01aAX+MkLkiCRow//95dt9r 3M=; b=BEdz9SrHEXlfOKr+Cu1o1a4UsOD/7uuyNY3klr60Ap/KaA5spxC+WRvu0 /iPGgRbwuvq3sNLZ36aFYSiHsBN3VcINzcott5Y/0inuT2RgInZQF2f+pL4fWtmx gJzdaP1k8GgWIwblZstpadalSbKHwFeEpmbR518AbXPZmx60t6qpiWJnI+MLpjjV GYJDInB4qCL2S+vKPtrmf3WJxXMWP4uKr5wHiZ3CiRSW8GMNB7xO80/kDn3mlRUR RYeMGaaiSLoqDBPe/UgdOVwxLHbnu0PrkL0noRYfsxVKkEv5QAoDO9LJeBapw+aP zqZ9b3KeONFAusnDaNAQragOSigjQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekjedgudeiudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4E4BD24005A; Mon, 12 Apr 2021 17:16:40 -0400 (EDT) From: Thomas Monjalon To: Xueming Li Cc: Gaetan Rivet , dev@dpdk.org, Asaf Penso Date: Mon, 12 Apr 2021 23:16:37 +0200 Message-ID: <4995828.0Bq7md6tjP@thomas> In-Reply-To: <1618064637-16413-5-git-send-email-xuemingl@nvidia.com> References: <1618064637-16413-1-git-send-email-xuemingl@nvidia.com> <1618064637-16413-5-git-send-email-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 4/5] bus: add device arguments name parsing API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/04/2021 16:23, Xueming Li: > + /* Resolve devarg's name. */ s/devarg's name/devargs name/ > + if (bus && bus->devargs_parse) Please make checks explicits with != NULL > + ret = bus->devargs_parse(devargs); > + else if (layers[0].kvlist != NULL) > + ret = devargs_bus_parse_default(devargs, layers[0].kvlist); [...] > +/** > + * Parse device arguments, setting the device name in the devargs as a result. It should be " Parse bus part of the device arguments. The field name of the struct rte_devargs will be set. " > + * > + * On error rte_errno is set. This sentence can be below (in @return section). > + * > + * @param da > + * Pointer to the devargs to parse. > + * The 'bus_str' field must be set. Why "must"? It should be optional, so this sentence should be removed. > + * > + * @return > + * 0 on successful parsing. > + * -EINVAL: on parsing error. > + * -ENODEV: if no key matching a device argument is specified. > + * -E2BIG: device name is too long. > + */ > +typedef int (*rte_bus_devargs_parse_t)(struct rte_devargs *da); [...] > + rte_bus_devargs_parse_t devargs_parse; /**< Parse device arguments */ Should be "Parse bus devargs"