From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 58FE4A0C43;
	Wed, 20 Oct 2021 13:55:32 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1982640687;
	Wed, 20 Oct 2021 13:55:32 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id D100840142
 for <dev@dpdk.org>; Wed, 20 Oct 2021 13:55:30 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 342447F530;
 Wed, 20 Oct 2021 14:55:30 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 342447F530
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1634730930;
 bh=JfMsB3AthT6Pd9CxGeB+xwYl1LJeUtu9J8RbV3UQMiY=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=tKSDFCOXxllxg9xGyHKdggEzfh/eJjKa+flV3bO4I998YpYwHiAUvLtbGbSD0sZkd
 4QUffW8SCOYdB793rdt0Aw8kOGtkXjggkm5eguDSYWRLjeLIj9ON3AjIREcTaFpFl0
 Iq3g6Q/GvUFrFt7QKBt8AyG4KWWFP5Of8SjMP6H0=
To: Ferruh Yigit <ferruh.yigit@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
References: <20211014083704.2542493-1-andrew.rybchenko@oktetlabs.ru>
 <20211020074257.2349486-1-andrew.rybchenko@oktetlabs.ru>
 <2b9849ac-4984-90b5-41d2-237aef0715d6@intel.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <49b6229a-0db7-180f-6a08-315facf53916@oktetlabs.ru>
Date: Wed, 20 Oct 2021 14:55:30 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <2b9849ac-4984-90b5-41d2-237aef0715d6@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v2 0/9] ethdev: cosmetic fixes
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/20/21 12:31 PM, Ferruh Yigit wrote:
> On 10/20/2021 8:42 AM, Andrew Rybchenko wrote:
>> Sicne rte_eth_dev and rte_eth_dev_data structures are just moved
>> right now is a good chance to make a cleanup. Moreover ethdev is
>> or will be shuffled a lot in the release, so do cleanup in all
>> files.
>>
>> Maybe at least some fixes from below could be accepted.
>>
>> Spelling is fixed in log messages as well. Hopefully it isn ot a
>> problem, but let me know if I'm wrong and I'll avoid it in the
>> next version.
>>
>> Since changes are cosmetic no Fixes tags and no backporting to
>> stable.
>>
>> Andrew Rybchenko (9):
>>    ethdev: avoid documentation in next lines
>>    ethdev: fix Rx/Tx spelling
>>    ethdev: fix Ethernet spelling
>>    ethdev: fix DCB and VMDq spelling
>>    ethdev: fix VLAN spelling including VLAN ID case
>>    ethdev: fix ID spelling in comments and log messages
>>    ethdev: remove reserved fields from internal structures
>>    ethdev: make device and data structures readable
>>    ethdev: remove full stop after short comments and references
>>
> 
> I am OK with changes in principal, will look more detailed later.
> 
> Only patch 9/9 also can be extended to whole file, instead of just
> moved structures.

OK, I'll send v3 in an hour.