DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thinh Tran <thinhtr@linux.vnet.ibm.com>
To: dev@dpdk.org
Cc: drc@linux.vnet.ibm.com
Subject: Re: [dpdk-dev] [PATCH] eal/ppc64: improve rte_rdtsc with ppc_get_timebase
Date: Fri, 31 Jan 2020 08:54:04 -0600	[thread overview]
Message-ID: <49e369df-b726-c52a-2743-b006febdc28f@linux.vnet.ibm.com> (raw)
In-Reply-To: <20200128210233.691-1-thinhtr@linux.vnet.ibm.com>

Need to resubmit a new patch, since the same code may be used by other 
ppc platform such as FreeBSD that may not have the sys/platform/ppc.h
Thinh Tran
On 1/28/2020 3:02 PM, Thinh Tran wrote:
>    __ppc_get_timebase() is GNU extention and is more efficient
> 
> Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> ---
>   .../common/include/arch/ppc_64/rte_cycles.h   | 28 ++-----------------
>   1 file changed, 2 insertions(+), 26 deletions(-)
> 
> diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h b/lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h
> index 8f2e98642..871f9b6e4 100644
> --- a/lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h
> +++ b/lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h
> @@ -14,6 +14,7 @@ extern "C" {
> 
>   #include <rte_byteorder.h>
>   #include <rte_common.h>
> +#include <sys/platform/ppc.h>
> 
>   /**
>    * Read the time base register.
> @@ -24,32 +25,7 @@ extern "C" {
>   static inline uint64_t
>   rte_rdtsc(void)
>   {
> -	union {
> -		uint64_t tsc_64;
> -		RTE_STD_C11
> -		struct {
> -#if RTE_BYTE_ORDER == RTE_BIG_ENDIAN
> -			uint32_t hi_32;
> -			uint32_t lo_32;
> -#else
> -			uint32_t lo_32;
> -			uint32_t hi_32;
> -#endif
> -		};
> -	} tsc;
> -	uint32_t tmp;
> -
> -	asm volatile(
> -			"0:\n"
> -			"mftbu   %[hi32]\n"
> -			"mftb    %[lo32]\n"
> -			"mftbu   %[tmp]\n"
> -			"cmpw    %[tmp],%[hi32]\n"
> -			"bne     0b\n"
> -			: [hi32] "=r"(tsc.hi_32), [lo32] "=r"(tsc.lo_32),
> -			[tmp] "=r"(tmp)
> -		    );
> -	return tsc.tsc_64;
> +	return __ppc_get_timebase();
>   }
> 
>   static inline uint64_t
> 

  parent reply	other threads:[~2020-01-31 15:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-28 21:02 Thinh Tran
2020-01-31  0:15 ` David Christensen
2020-01-31 14:54 ` Thinh Tran [this message]
2020-01-31 22:03 ` [dpdk-dev] [PATCH v2] " Thinh Tran
2020-02-04 18:00   ` David Christensen
2020-02-05 21:29   ` David Marchand
2020-02-10 17:53     ` Thinh Tran
2020-03-10 12:55   ` David Marchand
2020-03-11 20:26     ` Thinh Tran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49e369df-b726-c52a-2743-b006febdc28f@linux.vnet.ibm.com \
    --to=thinhtr@linux.vnet.ibm.com \
    --cc=dev@dpdk.org \
    --cc=drc@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).