From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D63A8A0C4E; Sun, 1 Aug 2021 12:57:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4983240143; Sun, 1 Aug 2021 12:57:49 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2064.outbound.protection.outlook.com [40.107.94.64]) by mails.dpdk.org (Postfix) with ESMTP id D416440140 for ; Sun, 1 Aug 2021 12:57:47 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U/J1KaXnyn2uyFfAkvD+r3EHisemtqDU+Z0MVg+HJdeFI4jQUtGyaHPKs6Uaq47vGAi2oIG3V1EkNu06sTPcKWDC5rkpxBiH1t18G29MR2qmulEljPvT6MYZLyboYcqx0wEnsIO/lDxL8p8ouMBb3c6ikciSRkKjScYIogiGUM2FuFRdngTeBbe6tAPo+DduF4+8+U6WxXqSfr/YHy0sAJhTuElp8qpn4zhRw3fvQdYI/ZJenaojex9dsh7F5VZuiIkFjpT0EtCHgEeHTBpOHYJhqV+voDPqim1Qna89XA9SBCjd7i0qBFk1cPKfRYEKFV59eJA3TU61odzWSp/tHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tbWJSBjbHLH46bZW8TPHfbvBbnKIWtH+8Zbb0I3sr5o=; b=J1I82l7aCsR7iJPgcfD5LZoZjLf76N8dPmMwQgPmteoiiNPfyd1cafkEv2xBI9FymqelLZxuVTuIl4FFx1nSW6Vihi7CL5Y8mLtcn0Zip6xRRenie56Dnb7TpdbW0Cr+MWWtr+iMNzMKY7fEltSo2ZbX+GO0cIKJ9yZGKWGmDMIGWAaLSt8bh+39GahjRsDac94ho1x3OhEukymT5+TSf8UDNC19uG5vZNrsVK5IMSnhSzsazkKrCVViu+EGRQZJfCA/fVQfMfoVzQaLcij/mvPoyt5rAZvjd2Id92KFii2KXsZbUw+UqBp0T+kp6Hah+IqhFLzHDZuhXHHfOLHZKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tbWJSBjbHLH46bZW8TPHfbvBbnKIWtH+8Zbb0I3sr5o=; b=VKH+f+U+xW+kah7FIktMnUt0PyZuA+vqSEiNdOg13aCrO/n+RXZ4wS6udYWHuzdMQGMLHztWZpywsKf3KLHKVPbxJnK9C41g5ATFSdO+nRmCcNvZA62OYre/M7ihUVKzWbEsk5ioLWSOQYKSwfH4RSC3mlBXwW/8/t9M0ua1psgL9cx3CjG+SKZL1+3NZGX7U5VK07dTHH4ELlpFZth8oQ2sJDRcOfQ/dPii4qwW2MDOpSonWF/8RoUisjyB2DFpRawxdUPyjE5hOe+R3cZr3eAmEHCHAjCs/ZUIGp5/t+tIe2Jn7kGeShK0zsr2/DPw0lfwbZMtNsgSHuPrC/mlGA== Received: from MWHPR02CA0007.namprd02.prod.outlook.com (2603:10b6:300:4b::17) by SN6PR12MB4687.namprd12.prod.outlook.com (2603:10b6:805:12::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.25; Sun, 1 Aug 2021 10:57:44 +0000 Received: from CO1NAM11FT059.eop-nam11.prod.protection.outlook.com (2603:10b6:300:4b:cafe::c) by MWHPR02CA0007.outlook.office365.com (2603:10b6:300:4b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Sun, 1 Aug 2021 10:57:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT059.mail.protection.outlook.com (10.13.174.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4373.18 via Frontend Transport; Sun, 1 Aug 2021 10:57:43 +0000 Received: from [172.27.13.188] (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 1 Aug 2021 10:57:40 +0000 To: Andrew Rybchenko , Thomas Monjalon , Ferruh Yigit , Ori Kam CC: , Ilya Maximets , Ajit Khaparde , Matan Azrad , Ivan Malov , Viacheslav Galaktionov References: <20210801102214.1566104-1-andrew.rybchenko@oktetlabs.ru> From: Eli Britstein Message-ID: <49eca7ed-ad3b-d47c-99d1-9ac109efc31a@nvidia.com> Date: Sun, 1 Aug 2021 13:57:37 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210801102214.1566104-1-andrew.rybchenko@oktetlabs.ru> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8abec65d-bb74-4af7-7f49-08d954db309a X-MS-TrafficTypeDiagnostic: SN6PR12MB4687: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8bNvZyDvwU4VBNwo0P2AR/izMn3F1sAJQSwUKD2yAl1e1oGOV1C+xXFM7teTOEecKzEGOgCYDLI260Lx1Yjspcvf1sgcgre7t9RM9zQRjRuXPhzdyhtabvQuAMJh+0OVjcbQd4pIY26kMANfxVFo84+DAcCpuM4J/YtySAzCQFtyWHD/H4iexLrO0T/NUwh0o+nU4H2RFeklxBZ3PdwTy9P5GP0vVhWvb6GMF9dchfL3mcIyof4g7/Q4ikX0UI9D6MKTRShyZuOZPpyeL0ufM2aditagyNHS4j4ATHDQUo3442rucgltOXWudY2R+5uxf4ggBiAZ0GpOxFifNrWki+xK5BlReI5muSCinyCgvBL4yDaUWlu5ZDvsPwXAWNajdyR2a3J49gIEEf/aIvddjULP0rVmCci9ntITMBxe6PtjGiF7BwLxkFTQ6RHIOBAqSlOdNyeVkBtPnEqqN8a3ZXVAJBGpDFBlnn1Oxs6mSOcHeu3knWC07iVMJwNHTnq4Yhhgwsvr/ZjV4cYoDeX2YZN+HUTQW0B2/xP4DoMC53DfALT6InzSmcUoXJVdstKk6rm4utuHL7HtwZHSjp7HAF9JWIbEdTtbJSRtpilucmaO5WHVGBcFw5zBdAKAKFlZ1g4j0brWuwcp/00QJDUiElJch0F/C0mT74mg0rpGnmdFroEJhob+EXbGC/cwgd2h2biGavBa6ghJbCViXaAhpzG9ITf9LK66EBVBkNBhqiI= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(346002)(39860400002)(376002)(136003)(36840700001)(46966006)(6636002)(6666004)(8936002)(2906002)(53546011)(426003)(26005)(7636003)(31696002)(8676002)(82740400003)(2616005)(86362001)(356005)(336012)(16526019)(47076005)(31686004)(83380400001)(186003)(36756003)(5660300002)(54906003)(4326008)(82310400003)(110136005)(16576012)(70586007)(70206006)(478600001)(316002)(36906005)(36860700001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2021 10:57:43.8548 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8abec65d-bb74-4af7-7f49-08d954db309a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT059.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB4687 Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: announce flow API action PORT_ID changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/1/2021 1:22 PM, Andrew Rybchenko wrote: > External email: Use caution opening links or attachments > > > By its very name, action PORT_ID means that packets hit an ethdev with the > given DPDK port ID. At least the current comments don't state the opposite. > That said, since port representors had been adopted, applications like OvS > have been misusing the action. They misread its purpose as sending packets > to the opposite end of the "wire" plugged to the given ethdev, for example, > redirecting packets to the VF itself rather than to its representor ethdev. > Another example: OvS relies on this action with the admin PF's ethdev port > ID specified in it in order to send offloaded packets to the physical port. > > Since there might be applications which use this action in its valid sense, > one can't just change the documentation to greenlight the opposite meaning. > > The documentation must be clarified and rte_flow_action_port_id structure > should be extended to support both meanings. I think the only clarification needed is that PORT_ID acts as if rte_eth_tx_burst is called with the specified port-id. Regarding representors, it's not different. When using TX on a representor port, the packets appear as RX on its represented port. Please elaborate if there is a use case for the PORT_ID~ in which the app can get the packets using rte_eth_rx_burst on the specified port-id. > > Signed-off-by: Andrew Rybchenko > --- > doc/guides/rel_notes/deprecation.rst | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index d9c0e65921..6e6413c89f 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -158,3 +158,8 @@ Deprecation Notices > * security: The functions ``rte_security_set_pkt_metadata`` and > ``rte_security_get_userdata`` will be made inline functions and additional > flags will be added in structure ``rte_security_ctx`` in DPDK 21.11. > + > +* ethdev: Definition of the flow API action PORT_ID is ambiguous and needs > + clarification. Structure rte_flow_action_port_id will be extended to > + specify traffic direction to represented entity or ethdev port itself in > + DPDK 21.11. > -- > 2.30.2 >