From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49AFDA0C41; Fri, 16 Apr 2021 09:31:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BDDEE141B56; Fri, 16 Apr 2021 09:31:46 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id EE9CE141B55 for ; Fri, 16 Apr 2021 09:31:45 +0200 (CEST) IronPort-SDR: 2FHZ1RDl8Sokdkqlid5icT2NGLKXvRA6cC5f9JqIFDjEQ3UKu3VanGUqvJ3Hy4aAyLXRF4R+5c GAD/HI4THcxQ== X-IronPort-AV: E=McAfee;i="6200,9189,9955"; a="256318094" X-IronPort-AV: E=Sophos;i="5.82,226,1613462400"; d="scan'208";a="256318094" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2021 00:31:26 -0700 IronPort-SDR: EXSNxYR5vhKpMGlOVdKYAOZt0BX+/hXWddp51Kz3nhQyxtTH0jAobcnvl/6p09Fd7+bPC6GUOS 0vzeYqq8SLKA== X-IronPort-AV: E=Sophos;i="5.82,226,1613462400"; d="scan'208";a="425492837" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.207.150]) ([10.213.207.150]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2021 00:31:25 -0700 To: oulijun , linuxarm@openeuler.org, dev References: <1616670560-62333-1-git-send-email-oulijun@huawei.com> <1618454426-21457-1-git-send-email-oulijun@huawei.com> <41261214-284c-3f66-a5c7-14bbe0df65b0@intel.com> <9356626.RYGqZy0Vls@thomas> <8ded3a05-65b8-25b4-f10e-39cabe98603e@huawei.com> Cc: David Marchand , Ray Kinsella From: Ferruh Yigit X-User: ferruhy Message-ID: <49f6550a-26c0-d55d-4154-c8153fe7d2ee@intel.com> Date: Fri, 16 Apr 2021 08:31:21 +0100 MIME-Version: 1.0 In-Reply-To: <8ded3a05-65b8-25b4-f10e-39cabe98603e@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [Linuxarm] Re: [PATCH V3] ethdev: add queue state when retrieve queue information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/16/2021 1:58 AM, oulijun wrote: > > > 在 2021/4/15 20:45, Ferruh Yigit 写道: >> On 4/15/2021 1:36 PM, Thomas Monjalon wrote: >>> 15/04/2021 14:33, Ferruh Yigit: >>>> On 4/15/2021 3:40 AM, Lijun Ou wrote: >>>>> Currently, upper-layer application could get queue state only >>>>> through pointers such as dev->data->tx_queue_state[queue_id], >>>>> this is not the recommended way to access it. So this patch >>>>> add get queue state when call rte_eth_rx_queue_info_get and >>>>> rte_eth_tx_queue_info_get API. >>>>> >>>>> Note: After add queue_state field, the 'struct rte_eth_rxq_info' size >>>>> remains 128B, and the 'struct rte_eth_txq_info' size remains 64B, so >>>>> it could be ABI compatible. >>>>> >>>>> Signed-off-by: Chengwen Feng >>>>> Signed-off-by: Lijun Ou >>>> >>>> Looks good to me, but it is causing an ABI error as we already discussed before >>>> as that is false positive. >>>> >>>> >>>> Ray, David, >>>> >>>> Should we add any exception to libabigail.abignore for this? >>> >>> We do not tolerate any ABI warning. >>> If we are sure the ABI change is false positive, >>> it must be suppressed in libabigail.abignore in the same patch. >>> >> >> A new field is added to public structs, but struct size or the location of the >> existing fields are not changing (struct is cache aligned). >> >> Can you please support how this can be added to 'libabigail.abignore'? >> >> Lijun can you please send a new version with 'libabigail.abignore' update? >> > Yes, I can do that. But at the moment I don't know how to update > libabigil.abinore. I don't know where to modify > Is there any relevant documentation? Please check Thomas' response, he already described what needs to be changed. And for documentation David & Ray may know better.