From: "Wiles, Keith" <keith.wiles@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>
Cc: dev <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Patel, Amol" <amol.patel@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] net/tap: invoke probe finish for multiq failure
Date: Wed, 7 Nov 2018 15:11:46 +0000 [thread overview]
Message-ID: <4BCFFA6A-1160-484E-955A-F8A9E683B308@intel.com> (raw)
In-Reply-To: <20181107135817.15139-1-vipin.varghese@intel.com>
> On Nov 7, 2018, at 1:58 PM, Varghese, Vipin <vipin.varghese@intel.com> wrote:
>
> In scenarion for multiq or flowq setup failure rte_eth_dev_probing_finish
> has to be invoked for successful device registration.
>
Acked-by: Keith Wiles <keith.wiles@intel.com>
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> ---
> ---
> drivers/net/tap/rte_eth_tap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index e7817e896..40911923d 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -1848,6 +1848,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name,
> TAP_LOG(ERR, "Remote feature requires flow support.");
> goto error_exit;
> }
> + rte_eth_dev_probing_finish(dev);
> return 0;
>
> error_remote:
> --
> 2.17.1
>
Regards,
Keith
next prev parent reply other threads:[~2018-11-07 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 13:58 Vipin Varghese
2018-11-07 15:11 ` Wiles, Keith [this message]
2018-11-07 19:03 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCFFA6A-1160-484E-955A-F8A9E683B308@intel.com \
--to=keith.wiles@intel.com \
--cc=amol.patel@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=vipin.varghese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).